-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added more tests for Drop
#1285
Added more tests for Drop
#1285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, modulo comments.
Does this resolve all the open drop
testing issues?
@adpaco-aws thoughts on the file name/locations for these tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather have all drop-related tests in the Drop
folder so we have them all in one place. As long as their names refer to the types for which it's being tested (which they do), they're fine.
Co-authored-by: Adrian Palacios <[email protected]>
@adpaco-aws's suggestion.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description of changes:
Kani's behavior does not change. 4 tests are added to test Kani's behavior on the
Drop
trait. These test enums, channels,Rc<Refcell<T>>
and ownership-moving closures.Resolved issues:
Issue #1284
Call-outs:
tests/kani/Drop/fixme_drop_after_moving_across_channel.rs
) fails whenkani::unwind(1)
is set, and does not finish in under 10m whenkani::unwind(2)
is set. This will get a separate issue once merged.Testing
How is this change tested? All new test cases run with
scripts/kani-regression.sh
, also manually check that assertions are valid.Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.