Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore simd_shl and simd_shr intrinsics #1964

Merged
merged 10 commits into from
Dec 6, 2022
Merged

Restore simd_shl and simd_shr intrinsics #1964

merged 10 commits into from
Dec 6, 2022

Conversation

adpaco-aws
Copy link
Contributor

@adpaco-aws adpaco-aws commented Dec 5, 2022 •
edited
Loading

Description of changes:

  • Restores support for the simd_shl and simd_shr intrinsics.
  • Adds a bunch of tests for them.
  • Documents missing overflow check which isn't easy to reproduce.

Resolved issues:

Towards #1148
Opens #1963

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested? Existing regression + ~6 new tests.

  • Is this a refactor change? No.

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@adpaco-aws adpaco-aws requested a review from a team as a code owner December 5, 2022 23:51
zhassan-aws
zhassan-aws reviewed Dec 6, 2022
View reviewed changes
tests/expected/simd-shl-operand-negative/main.rs Outdated Show resolved Hide resolved
tests/expected/simd-shl-shift-negative/main.rs Outdated Show resolved Hide resolved
tests/expected/simd-shl-shift-too-large/main.rs Outdated Show resolved Hide resolved
tests/kani/Intrinsics/SIMD/Operators/bitshift.rs Outdated Show resolved Hide resolved
tests/kani/Intrinsics/SIMD/Operators/bitshift.rs Outdated Show resolved Hide resolved
@adpaco-aws adpaco-aws merged commit 3373698 into model-checking:main Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhassan-aws zhassan-aws zhassan-aws approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adpaco-aws @zhassan-aws