Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stub linker to avoid missing symbols errors #3858

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

celinval
Copy link
Contributor

Kani compiler does not generate real object files when compiling a crate and its dependencies for verification. Instead, the compiler generates goto binaries. This can cause linking errors. Instead, stub it with echo.

We should consider creating a stub linker instead, but echo will do it for now.

Note that this change only applies to target artifacts, not those compiled for the host, such as build dependencies and build scripts.

Resolves #3817

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

Kani compiler does not generate real object files when compiling a crate
and its dependencies for verification. Instead, the compiler generates
goto binaries. This can cause linking errors. Instead, stub it with
echo.

We should consider creating a stub linker instead, but echo will do it
for now.

Note that this change only applies to target artifacts, not those
compiled for the host, such as build dependencies and build scripts.
@celinval celinval requested a review from a team as a code owner January 27, 2025 23:20
Copy link
Contributor

@zhassan-aws zhassan-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@celinval celinval added this pull request to the merge queue Jan 28, 2025
Merged via the queue into model-checking:main with commit bc134ce Jan 28, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kani fails to compile a crate but cargo can build it
2 participants