Still...

moderndive · Sep 21, 2024 · b270bcc · b270bcc
1 parent 8b45121
commit b270bcc
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 13 deletions.
diff --git a/.github/workflows/deploy_bookdown.yml b/.github/workflows/deploy_bookdown.yml
@@ -56,15 +56,13 @@ jobs:
           key: bookdown-${{ hashFiles('**/*Rmd') }}
           restore-keys: bookdown-
 
-      - name: Build HTML book
+      - name: Build PDF book
         run: |
-          R -e 'bookdown::render_book(\"index.Rmd\", \"bookdown::bs4_book\")'
-        shell: Rscript {0}
+          R -e 'bookdown::render_book("index.Rmd", "bookdown::pdf_book")'
 
-      - name: Build PDF book
+      - name: Build HTML book
         run: |
-          R -e 'bookdown::render_book(\"index.Rmd\", \"bookdown::pdf_book\")'
-        shell: Rscript {0}
+          R -e 'bookdown::render_book("index.Rmd", "bookdown::bs4_book")'
 
       # Deploy HTML to GitHub Pages if on main or master branch
       - name: Deploy to GitHub pages 🚀

diff --git a/10-inference-for-regression.Rmd b/10-inference-for-regression.Rmd
@@ -2472,7 +2472,7 @@ We can now conduct hypothesis tests for the partial slopes in multiple linear re
 
 We can visualize the $p$-values in the null distribution by comparing them to the observed test statistics. We do this by adding a `shade_p_value()` layer to the `visualize()` function. 
 
-```{r, fig.height=6, fig.width=6, fig.cap="Shaded p-values for the partial slopes in this multiple linear regression."}
+```{r, fig.height=ifelse(knitr::is_latex_output(), 6, 8), fig.width=6, fig.cap="Shaded p-values for the partial slopes in this multiple linear regression."}
 visualize(null_distribution_mlr) +
   shade_p_value(obs_stat = observed_fit, direction = "two-sided")
 ```

diff --git a/_includes/logo.html b/_includes/logo.html
@@ -1,3 +1,3 @@
 <html>
-<img src="https://moderndive.com/wide_format.png" alt="ModernDive" style="max-width: 600px; display: block; margin: 0 auto; padding-top: 10px;">
+<img src="https://moderndive.com/wide_format.png" alt="ModernDive" style="max-width: 550px; display: block; margin: 0 auto; padding-top: 10px;">
 </html>
diff --git a/index.Rmd b/index.Rmd
@@ -66,7 +66,7 @@ opts_chunk$set(
   fig.pos = 'H',
   fig.retina = 1,
   fig.width = 6,
-  fig.asp = if(knitr::is_latex_output()) "2/3"
+  fig.asp = if(knitr::is_html_output()) "2/3"
 )
 ```
 
@@ -80,7 +80,7 @@ needed_CRAN_pkgs <- c(
   
   # Packages only used internally for bookdown book building
   "devtools", "ggrepel", "here", "kableExtra", "mvtnorm", "patchwork", 
-  "remotes", "rmarkdown", "sessioninfo", "viridis", "webshot"
+  "remotes", "rmarkdown", "sessioninfo", "viridis", "webshot", "gridExtra"
 )
 new_pkgs <- needed_CRAN_pkgs[!(needed_CRAN_pkgs %in% installed.packages())]
 if (length(new_pkgs)) {
@@ -97,10 +97,13 @@ write_bib(
   c(
     .packages(), 
     "bookdown", "broom", "dplyr", "dygraphs", "fivethirtyeight", "ggplot2", 
-    "ggplot2movies", "infer", "janitor", "kableExtra", "knitr", "moderndive", 
-#    "nycflights13", 
+    "ggplot2movies", "infer", "ISLR2",
+    "janitor", "kableExtra", "knitr", "moderndive", 
+    #    "nycflights13", 
     "nycflights23",
-    "readr", "rmarkdown", "skimr", "tibble", "tidyr", "tidyverse", "webshot"
+    "readr", "rmarkdown", 
+    #    "skimr",
+    "tibble", "tidyr", "tidyverse", "webshot"
   ),
   here::here("bib", "packages.bib")
 )