fix(test-runner-saucelabs): use correct SauceLabsCapabilities type #2874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
SauceLabsCapabilities
object tocreateSauceLabsLauncher
Notes
The parameter is specifically for providing SauceLabs capabilities and is destructured into
sauce:options
in the final capabilities object:web/packages/test-runner-saucelabs/src/createSauceLabsLauncher.ts
Lines 48 to 51 in 12d0de4
Thus the type should also reflect that the parameter should contain Sauce Labs capabilities and not all Web Driver capabilities. You can see this being an issue in
packages/test-runner-saucelabs/test-remote/saucelabsLauncher.test.ts
for example, which doesn't compile ATM.