Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test-runner-saucelabs): use correct SauceLabsCapabilities type #2874

Merged

Conversation

sissbruecker
Copy link
Contributor

What I did

  1. Fixed type for providing a SauceLabsCapabilities object to createSauceLabsLauncher

Notes

The parameter is specifically for providing SauceLabs capabilities and is destructured into sauce:options in the final capabilities object:

finalCapabilities['sauce:options'] = {
...finalSauceCapabilities,
...(finalCapabilities['sauce:options'] || {}),
};

Thus the type should also reflect that the parameter should contain Sauce Labs capabilities and not all Web Driver capabilities. You can see this being an issue in packages/test-runner-saucelabs/test-remote/saucelabsLauncher.test.ts for example, which doesn't compile ATM.

Copy link

changeset-bot bot commented Jan 30, 2025

🦋 Changeset detected

Latest commit: 736e669

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/test-runner-saucelabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bashmish
Copy link
Member

thanks!

@bashmish bashmish merged commit 21740b1 into modernweb-dev:master Jan 30, 2025
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants