Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#42: init implementation for yajsw #99
base: master
Are you sure you want to change the base?
#42: init implementation for yajsw #99
Changes from 2 commits
d1ff887
d8ac686
09c73ce
5681d63
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do all these libraries have to have hardocded versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, yes, because the version number is part of their name in the path. These libs are part of the YAJSW jar, that I downloaded before. YAJSW needs these libs for working correctly. See also my comment in the issue about the structure of YAJSW
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get what you're saying, but each time there is an upgrade of the
yajsw
library, these lines (here and below) will have to be manually updated. Would it be possible to implement a cleaner way of doing this? For example, you can scan the directories for these jar files by a pattern and resolve the paths this way. I know it's a bit of extra work, but it will save a lot of work in the future when there's upgrades (and you know how error prone these manual "touches" tend to be)...There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely with you. Maintenance will be very hard with this solution. I would spend more time for a better solution when one of maintainers give feedback whether I run in the right direction with this PR.
IMHO the best solution would be when YAJSW would provide a normal Maven artifact in Maven central.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do they have an issue open for this that would could link to, (or make some noise)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khmarbaise ,
Any feedback on this pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It exists an elder ticket, but it doesn't address our problem.
@carlspring could you open a ticket and link it in our original issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean. Perhaps it would be easier/clearer for you to do it?