Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stream inheritance for the forked process #71

Closed
gnodet opened this issue Jan 5, 2017 · 6 comments
Closed

Support stream inheritance for the forked process #71

gnodet opened this issue Jan 5, 2017 · 6 comments

Comments

@gnodet
Copy link
Contributor

gnodet commented Jan 5, 2017

Related to a jline issue.
Java 7 introduced the ability to inherit standard streams using the inheritIO() method.
It would be really nice to be able to support it.

gnodet added a commit to gnodet/exec-maven-plugin that referenced this issue Jan 5, 2017
@gnodet
Copy link
Contributor Author

gnodet commented Jan 12, 2017

@olamy, would you mind having a look at this PR if you have a few minutes ?

@olamy
Copy link
Member

olamy commented Jan 15, 2017

@gnodet LGTM please do a real pr. ATM it's only a change in your fork :-)

@gnodet
Copy link
Contributor Author

gnodet commented Jan 16, 2017

@olamy The related PR is #72

@khmarbaise
Copy link
Member

It would be great having an unit or integration test for this?

@gnodet
Copy link
Contributor Author

gnodet commented Jan 30, 2017

Fair enough, I'll have a look.

@gnodet
Copy link
Contributor Author

gnodet commented Feb 3, 2017

I wrote an integration test, but unfortunately, I don't see a good way to make it work.
The reason is that the way I thought about testing that is to run the tty unix command which returns the name of the terminal device. If the inheritIo flag works, it should be an existing terminal, else the command returns not a tty. The problem is that this can only work if the maven process actually has a terminal correctly set up (that's the exact problem I'm trying to solve for the exec'ed process here). So in order for that to work, it would require the maven-invoker-plugin to also be able to inherit the terminal. Furthermore, this would also only work if running from a real terminal, so that automated testing in jenkins or such may not work.

gnodet added a commit to gnodet/exec-maven-plugin that referenced this issue Mar 5, 2021
gnodet added a commit to gnodet/exec-maven-plugin that referenced this issue Mar 5, 2021
@olamy olamy closed this as completed in 9c2c667 May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants