Fixes #160, ensure the java classloader is a child first one and supports to excludes some gathered classpath element to solve manually conflicts #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and supports to excludes some gathered classpath element to solve manually conflicts
olamy
reviewed
Jul 21, 2020
| <mainClass>org.codehaus.mojo.exec.Slf4jMain</mainClass> | ||
| <!-- simulate plugin deps bringing one binding and project deps bringing another one --> | ||
| <additionalClasspathElements> | ||
| <additionalClasspathElements>../../../../target/test-classes</additionalClasspathElements> <!-- test setup requires it --> |
There was a problem hiding this comment.
<nit_picking> I would prefer something such @project.basedir@ or whatever use some interpolation </nit_picking>
There was a problem hiding this comment.
Hmm, me too but it is not ran with it plugin so it is not interpolated this way. Should I impl it in the "test mock" handling?
There was a problem hiding this comment.
this should do the trick in main pom
<scriptVariables>
<mainproject.testOutputDirectory>${project.build.testOutputDirectory}</mainproject.testOutputDirectory>
</scriptVariables>
in src/test/projects/project16/pom.xml
<additionalClasspathElements>@mainproject.testOutputDirectory@</additionalClasspathElements>
please rebase as I have added some ghactions in master to verify the build
thanks!
There was a problem hiding this comment.
@olamy scriptVariables is in invoker plugin right? The test uses the pseudo mock ran with surefire so not sure how it would match? 🤔
olamy
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.