Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ITs for set goal #1106

Closed
slawekjaranowski opened this issue Jul 3, 2024 · 0 comments · Fixed by #1107 or #1112
Closed

Improve ITs for set goal #1106

slawekjaranowski opened this issue Jul 3, 2024 · 0 comments · Fixed by #1107 or #1112
Milestone

Comments

@slawekjaranowski
Copy link
Member

slawekjaranowski commented Jul 3, 2024

We have about 37 - versions-maven-plugin/src/it/it-set-* integrations test for set goal ...
but looks like not cover every cases.

Before working on issue like: #1103 will be appreciated to refresh a little those.

Task to do:

  • add a url with link to source issue as possible to discover
  • drop invoker.nonRecursive from invoker.properties as set goal is aggregate already
  • drop not used pluginManagement from poms
  • rewrite verify scripts
    • change to groovy
    • use XmlSlurper for verifying
    • check all items in all modules - what are changed - can be done be diff eg on: target/it/it-set-001/pom.xml target/it/it-set-001/pom.xml.versionsBackup

Step for quick checks:

  • mvn install - need only once
  • mvn verify -DskipTests -pl versions-maven-plugin -P run-its -Dinvoker.test=it-set-\*

Can be done one by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant