-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add an option to exclude parent from properties updates #793
Comments
This is a result of fixing #367. Indeed, very valid request. I'll definitely consider it. |
New option: Adding the same option to |
…and PropertyUpdatesReport
…and PropertyUpdatesReport
…and PropertyUpdatesReport
…and PropertyUpdatesReport
Should this Since upgrading from 2.12.0 to 2.13.0, the update-properties for a reactor project takes much much longer and is way more verbose than before. In every reactor module, I get the same message about properties being unchanged, whereas before I would only see this in the root module. |
I agree that it's more chatty than before. It's a side effect of #367. I think it doesn't really add any value there. While it will discover property updates from parent POMs, it won't be able to modify them anyway. So it's a genuine bug, which needs to be addressed, not just a question of providing the property there. What's worse, versions-changes.xml will record a change that did not occur. |
@edwinvanderham |
Edit -- it does matter after all if the child POM redefines a property defined and used in the parent. - #582 So, I'll add |
@ajarmoniuk thank you for the quick response |
Since version 2.13.0, the
display-property-updates
goal shows many properties updates for Spring Boot based projects.Spring Boot projects use a Spring Boot parent pom which declares a BOM with many dependencies and their corresponding version properties.
Even if we don't actually use these dependencies (they are declared in a
dependencyManagement
block), thedisplay-property-updates
goals now shows updates for all of these properties.I think it would be useful to provide a parameter that allows us to ignore version properties updates from parent's pom. If this parameter already exists, could you please update the documentation https://www.mojohaus.org/versions-maven-plugin/display-property-updates-mojo.html?
Thanks!
How to reproduce: create a sample Maven project with https://start.spring.io/. You can also test this project https://github.com/jonathanlermitage/spring-mvc-tiny-sample. Then, invoke
display-property-updates
and see the proposed properties updates.With plugin 2.12.0 I get:
With plugin 2.13.0 I get:
The text was updated successfully, but these errors were encountered: