Regression in 2.14.0 #848

Artur- · 2022-12-14T10:01:29Z

git clone https://github.com/vaadin/flow.git
cd flow
mvn versions:set -DnewVersion=1.2.3

Expected outcome:
All modules are set to version 1.2.3, like with 2.13.0

Actual outcome:

[ERROR] 
java.nio.file.NoSuchFileException: /.../flow/flow-tests/test-npm-only-features/test-npm-bytecode-scanning/pom.xml
    at sun.nio.fs.UnixException.translateToIOException (UnixException.java:92)
    at sun.nio.fs.UnixException.rethrowAsIOException (UnixException.java:106)
    at sun.nio.fs.UnixException.rethrowAsIOException (UnixException.java:111)
    at sun.nio.fs.UnixFileSystemProvider.newByteChannel (UnixFileSystemProvider.java:219)
    at java.nio.file.Files.newByteChannel (Files.java:380)
    at java.nio.file.Files.newByteChannel (Files.java:432)
    at java.nio.file.spi.FileSystemProvider.newInputStream (FileSystemProvider.java:422)
    at java.nio.file.Files.newInputStream (Files.java:160)
    at org.codehaus.plexus.util.xml.XmlReader.<init> (XmlReader.java:129)
    at org.codehaus.plexus.util.xml.XmlStreamReader.<init> (XmlStreamReader.java:67)
    at org.codehaus.plexus.util.ReaderFactory.newXmlReader (ReaderFactory.java:122)
    at org.codehaus.mojo.versions.api.PomHelper.readXmlFile (PomHelper.java:1498)
    at org.codehaus.mojo.versions.AbstractVersionsUpdaterMojo.process (AbstractVersionsUpdaterMojo.java:326)
    at org.codehaus.mojo.versions.SetMojo.execute (SetMojo.java:381)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
    at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 (MojoExecutor.java:370)

and the version in the following modules is not updated:

flow-tests/test-ccdm-flow-navigation/pom-production.xml
flow-tests/test-ccdm/pom-production.xml
flow-tests/test-custom-frontend-directory/test-themes-custom-frontend-directory/pom-generatedTsDir.xml
flow-tests/test-frontend/test-npm/pom-production.xml
flow-tests/test-frontend/test-pnpm/pom-production.xml
flow-tests/test-frontend/vite-context-path/pom-production.xml
flow-tests/test-frontend/vite-embedded/pom-production.xml
flow-tests/test-frontend/vite-pwa-custom-offline-path/pom-production.xml
flow-tests/test-frontend/vite-pwa-disabled-offline/pom-production.xml
flow-tests/test-npm-only-features/test-npm-bytecode-scanning/pom-devmode.xml
flow-tests/test-npm-only-features/test-npm-bytecode-scanning/pom-prod-fallback.xml
flow-tests/test-npm-only-features/test-npm-bytecode-scanning/pom-production.xml
flow-tests/test-pwa-disabled-offline/pom-production.xml
flow-tests/test-pwa/pom-production.xml

The text was updated successfully, but these errors were encountered:

andrzejj0 · 2022-12-14T10:22:56Z

Gotcha. Sorry about that. I'll look into it.

pzygielo · 2022-12-14T10:56:45Z

I observe similar - version is not set in modules with parent not in ..

for modules with <parent>... <relativePath>../..</relativePath>

pzygielo · 2022-12-14T11:19:18Z

Sorry to hijack this issue, but perhaps it's related.
For my case: 96deb8e is the first bad commit.

pzygielo · 2022-12-14T11:34:14Z

I suppose it has something to do with the assumptions

versions/versions-common/src/main/java/org/codehaus/mojo/versions/api/PomHelper.java

Line 1219 in efec55e

if (moduleFile.isDirectory() && new File(moduleFile, "pom.xml").isFile()) {

versions/versions-common/src/main/java/org/codehaus/mojo/versions/api/PomHelper.java

Line 1302 in efec55e

File parentFile = new File(parentDir, "pom.xml");

that pom.xml is the right file name...

marthinmc · 2022-12-14T12:53:19Z

I have the same problem when I do mvn versions:set, please keep us informed

java.nio.file.NoSuchFileException: /home/jenkins/agent/workspace/curve-connector-test_release_0.2/dtos
13:05:59 at sun.nio.fs.UnixException.translateToIOException (UnixException.java:86)

ghost · 2022-12-14T13:02:13Z

Also have this issue

vanroda · 2022-12-14T13:09:48Z

Possible workarounds:

fixate plugin version in parent pom
<plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>versions-maven-plugin</artifactId> <version>2.13.0</version> </plugin>

OR

add version to the set cmd
mvn -q -f pom.xml org.codehaus.mojo:versions-maven-plugin:2.13.0:set

marthinmc · 2022-12-14T13:39:10Z

Possible workarounds:

fixate plugin version in parent pom
<plugin> <groupId>org.codehaus.mojo</groupId> <artifactId>versions-maven-plugin</artifactId> <version>2.13.0</version> </plugin>

add version to the set cmd
mvn -q -f pom.xml org.codehaus.mojo:versions-maven-plugin:2.13.0:set

it works for me! thanks. I didn't have to add it in the parent pom

…names

andrzejj0 · 2022-12-14T15:55:22Z

@pzygielo could you please share some details about your case? Alternatively, could you try your test case against my branch? Thanks

The old assumption about the "pom.xml" file in module directories dates back to the very beginning of the Set mojo. I wonder how (if) it worked in 2.13.0 (the mojo simply skipped files it couldn't resolve). Anyway, the original case as well a simplified case (it-set-issue-848) do work fine with the branch.

And the solution is simple -- since we already have the path, why not use it? :)

Everyone -- until this is released, please use

mvn org.codehaus.mojo:versions-maven-plugin:2.13.0

to get around the problem. Sorry about the inconvenience.

pzygielo · 2022-12-14T16:31:27Z

could you try your test case against my branch? Thanks

2.15.0-SNAPSHOT - built from 60cda6a, works fine 🎉

could you please share some details about your case?

Here it is extracted to minimum:

.
├── docs
│   └── issue
│       └── pom.xml
└── pom.xml

with top-level having

    <modules>
        <module>docs/issue</module>
    </modules>

and module with

    <parent>
        ...
        <relativePath>../..</relativePath>
    </parent>

If version not specified explicitly maven-cli downloads the latest Regression have been introduced in version 2.14.0 mojohaus/versions#848

If version not specified explicitly maven-cli downloads the latest Regression have been introduced in version 2.14.0 mojohaus/versions#848 (cherry picked from commit 9c1a68f)

fun2sh · 2022-12-14T18:01:39Z

could you try your test case against my branch? Thanks

2.15.0-SNAPSHOT - built from 60cda6a, works fine 🎉

could you please share some details about your case?

Here it is extracted to minimum:
.
├── docs
│   └── issue
│       └── pom.xml
└── pom.xml
with top-level having
    <modules>
        <module>docs/issue</module>
    </modules>
and module with
    <parent>
        ...
        <relativePath>../..</relativePath>
    </parent>

This is exactly what happens. When there is an intermediate parent directory without pom.xml, it fails to version bump that. It starts looking for that module in root of the project.

…names

ahannani-rms · 2022-12-14T19:17:43Z

we have the same issue right now plaguing all of our maven builds because versions:set is essentially resulting in a no-op.

andrzejj0 · 2022-12-14T19:21:35Z

we have the same issue right now plaguing all of our maven builds because versions:set is essentially resulting in a no-op.

@ahannani-rms as a workaround, please use

mvn org.codehaus.mojo:versions-maven-plugin:2.13.0:set

…names

rlucero-okta · 2022-12-14T19:36:18Z

Is it possible to remove 2.14.0 from maven repositories while the fix is still being worked on?

…names

akomakom · 2022-12-14T19:45:37Z

Is it possible to remove 2.14.0 from maven repositories while the fix is still being worked on?

Or push 2.14.1 with 2.13.0 content?

slawekjaranowski · 2022-12-14T19:47:20Z

Is it possible to remove 2.14.0 from maven repositories while the fix is still being worked on?

It is not possible: https://central.sonatype.org/faq/can-i-change-a-component/

By the way is good practice to specific plugins versions in project.

slawekjaranowski · 2022-12-14T19:48:39Z

I hope we will have a fix soon 😄

…names

2.14.0 has a bug (mojohaus/versions#848) that broke us. We should be pinning all build tool versions, anyway.

ghost · 2022-12-15T09:55:22Z

Yes - I think it's common to run, e.g., man versions:set for ad-hoc tasks; this means that in the absence of any POM configuration latest is pulled.

donhui · 2022-12-15T10:35:43Z

Also have this issue

alexsuter · 2022-12-15T11:09:58Z

Same issue here! Thanks for acting quick!

amoghmargoor · 2022-12-15T12:05:08Z

Thanks for responding quickly with a fix. really appreciate it.

slawekjaranowski · 2022-12-15T13:05:39Z

⚠️ Version 2.14.1 released - please retest

Artur- · 2022-12-15T13:11:00Z

I re ran my original test mentioned above using

mvn org.codehaus.mojo:versions-maven-plugin:2.14.1:set -DnewVersion=1.2.4

and it now produces identical results with 2.13 🎉

qds-x · 2022-12-15T13:19:44Z

warning Version 2.14.1 released - please retest

Can confirm this fixes the regression for me.

pzygielo · 2022-12-15T13:22:24Z

👍

…amatis Zampetakis reviewed by Laszlo Bodor) Freeze versions-maven-plugin to 2.13.0 to overcome the regression of 2.14.0 (mojohaus/versions#848) causing the failures in the nightly build. Using a fixed version is a good practice and can also prevent similar problems in the future. Closes apache#3860

vtintillier · 2022-12-15T15:33:04Z

2.14.1 fixes it, but for some reason 2.14.0 is still used by default if no version is set on the command line...

qds-x · 2022-12-15T16:29:48Z

2.14.1 fixes it, but for some reason 2.14.0 is still used by default if no version is set on the command line...

Yes I noticed the same, assumed it was just delayed propagation or something

slawekjaranowski · 2022-12-15T17:09:37Z

Updating of local stored artifact is done once per day in standard way - repositories->updatePolicy
https://maven.apache.org/settings.html#repositories

In order to pressure update use -U options, eg: mvn -U versions:help

msg7086 · 2022-12-15T19:03:43Z

Our project hits the issue since yesterday, now it works flawlessly. Thanks for the quick fix!

This doesn't solve GH-14949 (CI failure) because it's a problem of MojoHaus Versions Maven Plugin: mojohaus/versions#848 This adds more debug information on test failure. * Closes: #14949 Authored-by: Sutou Kouhei <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>

…amatis Zampetakis reviewed by Laszlo Bodor) Freeze versions-maven-plugin to 2.13.0 to overcome the regression of 2.14.0 (mojohaus/versions#848) causing the failures in the nightly build. Using a fixed version is a good practice and can also prevent similar problems in the future. Closes apache#3860

joviegas · 2022-12-20T01:19:09Z

mvn versions:commit

is failing with 2.14.1

This used to pass with 2.13.0 and also 2.14.0

<html><head></head><body>

[Container] 2022/12/19 21:42:49 Running command mvn versions:commit
--
[INFO] Scanning for projects...
Downloading from central: https://repo.maven.apache.org/maven2/com/amazonaws/aws-java-sdk-pom/1.12.368/aws-java-sdk-pom-1.12.368.pom
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[FATAL] Non-resolvable parent POM for com.amazonaws:aws-java-sdk-kinesisvideowebrtcstorage:1.12.368: Could not find artifact com.amazonaws:aws-java-sdk-pom:pom:1.12.368 in central (https://repo.maven.apache.org/maven2) and 'parent.relativePath' points at wrong local POM @ line 5, column 11

</body></html>

Also strange thing is this passes when the build is re-tried , it happens only first time

slawekjaranowski · 2022-12-20T06:10:53Z

@joviegas please create new issue - with simple project which allow us to reproduce.

andrzejj0 · 2022-12-20T06:56:08Z

@slawekjaranowski it's not an issue with the plugin -- it's not even been executed.

andrzejj0 · 2022-12-20T06:59:08Z

@joviegas when you execute a Maven command, Maven outputs which plugins it has executed and which modules (POM files) it has processed. In your example, Maven itself (not the plugin) had a problem processing the input files - it could not retrieve the parent file of one of the POM files. In any case, it's not an issue with this plugin.

joviegas · 2022-12-21T22:41:41Z

I pinned the maven plugin version to 2.13.0 and this fixed the issue , without any changes in our code/pom.

--- versions-maven-plugin:2.13.0

Note earlier it was picking the latest one that was 2.14.1 , and we started seeing this issue only for this version.

…amatis Zampetakis reviewed by Laszlo Bodor) Freeze versions-maven-plugin to 2.13.0 to overcome the regression of 2.14.0 (mojohaus/versions#848) causing the failures in the nightly build. Using a fixed version is a good practice and can also prevent similar problems in the future. Closes apache#3860 (cherry picked from commit 2cf058b)

…amatis Zampetakis reviewed by Laszlo Bodor) Freeze versions-maven-plugin to 2.13.0 to overcome the regression of 2.14.0 (mojohaus/versions#848) causing the failures in the nightly build. Using a fixed version is a good practice and can also prevent similar problems in the future. Closes apache#3860

andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Dec 14, 2022

Resolves mojohaus#848: Fixing module resolution with nonstandard file…

60cda6a

…names

Badya added a commit to JetBrains/kotlin that referenced this issue Dec 14, 2022

Specify versions-maven-plugin version explicitly

9c1a68f

If version not specified explicitly maven-cli downloads the latest Regression have been introduced in version 2.14.0 mojohaus/versions#848

andrzejj0 mentioned this issue Dec 14, 2022

display-plugin-updates-005 and -006 fail with maven older than 3.8.4 #850

Closed

slawekjaranowski mentioned this issue Dec 14, 2022

Resolves #505: getReactorModels using correct module paths when the module name includes pom.xml #805

Merged

andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Dec 14, 2022

Resolves mojohaus#848: Fixing module resolution with nonstandard file…

8061697

…names

slawekjaranowski mentioned this issue Dec 14, 2022

Resolves #848: Fixing module resolution with nonstandard filenames #849

Merged

andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Dec 14, 2022

Resolves mojohaus#848: Fixing module resolution with nonstandard file…

28bff23

…names

andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Dec 14, 2022

Resolves mojohaus#848: Fixing module resolution with nonstandard file…

3285e78

…names

andrzejj0 added a commit to andrzejj0/versions-maven-plugin that referenced this issue Dec 14, 2022

Resolves mojohaus#848: Fixing module resolution with nonstandard file…

4b5180e

…names

pzygielo mentioned this issue Dec 14, 2022

Upgrade versions-m-p to version with 848 fixed eclipse-ee4j/openmq#1636

Closed

millems added a commit to aws/aws-sdk-java-v2 that referenced this issue Dec 14, 2022

Pin versions-maven-plugin version to 2.13.0.

c520c57

2.14.0 has a bug (mojohaus/versions#848) that broke us. We should be pinning all build tool versions, anyway.

millems mentioned this issue Dec 14, 2022

Pin versions-maven-plugin version to 2.13.0. aws/aws-sdk-java-v2#3623

Merged

slawekjaranowski mentioned this issue Dec 15, 2022

java.nio.file.NoSuchFileException for nested maven modules #852

Closed

LuciferYang mentioned this issue Dec 15, 2022

[SPARK-41522][BUILD] Pin versions-maven-plugin to 2.13.0 to recover test-dependencies.sh apache/spark#39067

Closed

jadami10 mentioned this issue Dec 15, 2022

pin versions-maven-plugin to 2.13.0 apache/pinot#9993

Merged

slawekjaranowski closed this as completed Dec 16, 2022

slawekjaranowski mentioned this issue Dec 19, 2022

my congratulations to 2.14.0 #868

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Regression in 2.14.0 #848

Regression in 2.14.0 #848

Artur- commented Dec 14, 2022

andrzejj0 commented Dec 14, 2022

pzygielo commented Dec 14, 2022 •

edited

Loading

pzygielo commented Dec 14, 2022

pzygielo commented Dec 14, 2022

marthinmc commented Dec 14, 2022

ghost commented Dec 14, 2022

vanroda commented Dec 14, 2022 •

edited

Loading

marthinmc commented Dec 14, 2022

andrzejj0 commented Dec 14, 2022 •

edited

Loading

pzygielo commented Dec 14, 2022

fun2sh commented Dec 14, 2022

ahannani-rms commented Dec 14, 2022

andrzejj0 commented Dec 14, 2022 •

edited

Loading

rlucero-okta commented Dec 14, 2022

akomakom commented Dec 14, 2022

slawekjaranowski commented Dec 14, 2022

slawekjaranowski commented Dec 14, 2022

ghost commented Dec 15, 2022

donhui commented Dec 15, 2022

alexsuter commented Dec 15, 2022

amoghmargoor commented Dec 15, 2022

slawekjaranowski commented Dec 15, 2022

Artur- commented Dec 15, 2022

qds-x commented Dec 15, 2022

pzygielo commented Dec 15, 2022

vtintillier commented Dec 15, 2022

qds-x commented Dec 15, 2022

slawekjaranowski commented Dec 15, 2022

msg7086 commented Dec 15, 2022

joviegas commented Dec 20, 2022 •

edited

Loading

slawekjaranowski commented Dec 20, 2022

andrzejj0 commented Dec 20, 2022

andrzejj0 commented Dec 20, 2022 •

edited

Loading

joviegas commented Dec 21, 2022 •

edited

Loading

Regression in 2.14.0 #848

Regression in 2.14.0 #848

Comments

Artur- commented Dec 14, 2022

andrzejj0 commented Dec 14, 2022

pzygielo commented Dec 14, 2022 • edited Loading

pzygielo commented Dec 14, 2022

pzygielo commented Dec 14, 2022

marthinmc commented Dec 14, 2022

ghost commented Dec 14, 2022

vanroda commented Dec 14, 2022 • edited Loading

marthinmc commented Dec 14, 2022

andrzejj0 commented Dec 14, 2022 • edited Loading

pzygielo commented Dec 14, 2022

fun2sh commented Dec 14, 2022

ahannani-rms commented Dec 14, 2022

andrzejj0 commented Dec 14, 2022 • edited Loading

rlucero-okta commented Dec 14, 2022

akomakom commented Dec 14, 2022

slawekjaranowski commented Dec 14, 2022

slawekjaranowski commented Dec 14, 2022

ghost commented Dec 15, 2022

donhui commented Dec 15, 2022

alexsuter commented Dec 15, 2022

amoghmargoor commented Dec 15, 2022

slawekjaranowski commented Dec 15, 2022

Artur- commented Dec 15, 2022

qds-x commented Dec 15, 2022

pzygielo commented Dec 15, 2022

vtintillier commented Dec 15, 2022

qds-x commented Dec 15, 2022

slawekjaranowski commented Dec 15, 2022

msg7086 commented Dec 15, 2022

joviegas commented Dec 20, 2022 • edited Loading

slawekjaranowski commented Dec 20, 2022

andrzejj0 commented Dec 20, 2022

andrzejj0 commented Dec 20, 2022 • edited Loading

joviegas commented Dec 21, 2022 • edited Loading

pzygielo commented Dec 14, 2022 •

edited

Loading

vanroda commented Dec 14, 2022 •

edited

Loading

andrzejj0 commented Dec 14, 2022 •

edited

Loading

andrzejj0 commented Dec 14, 2022 •

edited

Loading

joviegas commented Dec 20, 2022 •

edited

Loading

andrzejj0 commented Dec 20, 2022 •

edited

Loading

joviegas commented Dec 21, 2022 •

edited

Loading