use-releases does not update parent

[alerosmile]

The use-release goal does not update the parent version. The useReleases method does detect required changes, but the
updateDependencyVersion method fails to write the updated version because this comparison is not valid for -SNAPSHOT versions. Artifact.getVersion() returns the timestamped version. In this case the version should be compared against Artifact.getBaseVersion().

I don't know why this comparison is needed anyway. Either remove the comparison or compare against Artifact.getVersion() and Artifact.getBaseVersion() and succeed if one of those succeeds.

[slawekjaranowski]

There is IT for use-latest-versions
https://github.com/mojohaus/versions/tree/master/versions-maven-plugin/src/it/it-use-latest-versions-011

So we can create similar for use-release

PR with fix are welcome.

[andrzejj0]

Hi, so it turns out that UseReleasesMojoTest::testProcessParent did not work as intended. Looking into this, but you're also free to provide a fix.

Turns out that test works fine because Artifact.getVersion() can return -SNAPSHOT if the version is a snapshot and not a timestamped version. I guess what we miss is a test testing against a timestamped version as well.

Verified that the goal does work on actual -SNAPSHOT parents.

Still, it doesn't work when the actual artifact in the repo is timestamped.

Using the mock-repository based integration tests doesn't let me reproduce the issue as I haven't found a way to provide metadata (baseVersion which resolves to an actual timestamped version) to the repos. So I'll create another unit test.

NB. The reason why that comparison is there is because the method gets applied to all dependencies fed to it - and in the case of the user updating both the parent and actual dependencies, this comparison acts as a way to select the dependency to update. I guess this might have been done differently.