Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#758: Implementing the first stage of module split #782

Merged
merged 8 commits into from
Nov 2, 2022

Conversation

andrzejj0
Copy link
Contributor

No description provided.

@andrzejj0
Copy link
Contributor Author

@slawekjaranowski Please review.

@andrzejj0
Copy link
Contributor Author

I think we need some kind of a commit freeze in order to commit this -- too many changes.

@andrzejj0 andrzejj0 force-pushed the issue-758-modules-jarek branch from 3c55c9f to 2bd0114 Compare October 29, 2022 07:29
@slawekjaranowski
Copy link
Member

I have worked a little on site output.

Please check by:

mvn site site:stage

and investigate output in target/staging/versions

@andrzejj0
Copy link
Contributor Author

andrzejj0 commented Oct 31, 2022

I have worked a little on site output.

Please check by:

mvn site site:stage

and investigate output in target/staging/versions

Maven site won't build anymore on Github.

Error: Failed to execute goal on project versions-maven-plugin: Could not resolve dependencies for project org.codehaus.mojo:versions-maven-plugin:maven-plugin:2.14.0-SNAPSHOT: The following artifacts could not be resolved: org.codehaus.mojo.versions:model-ruleset:jar:2.14.0-SNAPSHOT, org.codehaus.mojo.versions:model-report:jar:2.14.0-SNAPSHOT: Could not find artifact org.codehaus.mojo.versions:model-ruleset:jar:2.14.0-SNAPSHOT in ossrh-snapshots (https://oss.sonatype.org/content/repositories/snapshots) -> [Help 1]

Looks like maven site requires the artifacts to be present in the local repo. So we need to do install -P run-its instead of verify in maven-verify.yml?

By the way, why did you remove the XSD schemas of the reports from the XSD section? I can re-add those unless you explicitly wanted those removed...

@slawekjaranowski
Copy link
Member

By the way, why did you remove the XSD schemas of the reports from the XSD section? I can re-add those unless you explicitly wanted those removed...

I moved it to place where is generated ... for old versions of XSD we will need place a copy in root site to preserver old path.
We will change repo name ... 😄

@slawekjaranowski
Copy link
Member

Looks like maven site requires the artifacts to be present in the local repo. So we need to do install -P run-its instead of verify in maven-verify.yml?

I see - we use under site build current version of plugin ... it is tricky and sometime works, but with more dependencies for another module can stop working ...

To be clear we should used previous version of plugin for site build.

@andrzejj0
Copy link
Contributor Author

Looks like maven site requires the artifacts to be present in the local repo. So we need to do install -P run-its instead of verify in maven-verify.yml?

I see - we use under site build current version of plugin ... it is tricky and sometime works, but with more dependencies for another module can stop working ...

To be clear we should used previous version of plugin for site build

But that won't work - the previous version doesn't have modules 😏

Instead, why don't we do something like an extra Github Ci job before running site - Install with no tests, no enforcer, no chesktyle etc. Or compose that as an extra goal in the Site job?

@slawekjaranowski
Copy link
Member

I changed to instal for first step build ... I'm waiting for build ...

@slawekjaranowski
Copy link
Member

I'm want to go with this PR ... even more I can update site with snapshot version before release, so we can quickly resolve all site issues.

Next PR like enforcer rule can be put in separate module - What do you think?

@andrzejj0
Copy link
Contributor Author

I'm want to go with this PR ... even more I can update site with snapshot version before release, so we can quickly resolve all site issues.

Next PR like enforcer rule can be put in separate module - What do you think?

Definitely!

@andrzejj0
Copy link
Contributor Author

Can we merge?

@slawekjaranowski slawekjaranowski merged commit 780cf6e into mojohaus:master Nov 2, 2022
@slawekjaranowski slawekjaranowski added this to the 2.14.0 milestone Nov 2, 2022
@slawekjaranowski slawekjaranowski linked an issue Nov 2, 2022 that may be closed by this pull request
@slawekjaranowski
Copy link
Member

So, merged ... next release will be very interesting 😄

@slawekjaranowski
Copy link
Member

eeeh I forgot to squash 😠

@andrzejj0 andrzejj0 deleted the issue-758-modules-jarek branch November 3, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modularise the plugin
2 participants