Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 134 removing the no longer needed patch + adding integration tests #814

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

andrzejj0
Copy link
Contributor

@andrzejj0 andrzejj0 commented Nov 11, 2022

Looks like the patch is no longer needed. Tested with maven 3.2.5 as well as 3.6.3. Added integration tests which test against the case described in the issue.

Some explanation.

The removed method extracted the imported dependencies from the raw model, which were then used in addition to dependencies from the imported boms, which were added by Maven.

But, because the dependencies added by Maven are not present in the POM to be updated, processing them is simply wasted resources. Instead, it's much better to just process the raw model.

@andrzejj0
Copy link
Contributor Author

Waiting for #476

@andrzejj0 andrzejj0 marked this pull request as draft November 12, 2022 12:27
@andrzejj0 andrzejj0 force-pushed the issue-134-remove-patch branch 4 times, most recently from 267ed55 to 8fe726e Compare November 14, 2022 16:05
@andrzejj0
Copy link
Contributor Author

Looks like infrastructure problems again.

Could you please relaunch the failed jobs?

@andrzejj0 andrzejj0 marked this pull request as ready for review November 14, 2022 16:30
@andrzejj0
Copy link
Contributor Author

@slawekjaranowski please review

@andrzejj0
Copy link
Contributor Author

Resolves: #743, #308, #309, #346, #395

@andrzejj0 andrzejj0 force-pushed the issue-134-remove-patch branch from 8fe726e to 16bba7c Compare November 17, 2022 16:40
@andrzejj0 andrzejj0 force-pushed the issue-134-remove-patch branch from 16bba7c to 34e2305 Compare November 19, 2022 15:55
…etRawModel can be used instead. Adding more integration tests.
@andrzejj0 andrzejj0 force-pushed the issue-134-remove-patch branch from 34e2305 to 8fb889a Compare November 19, 2022 16:25
@andrzejj0
Copy link
Contributor Author

@slawekjaranowski please review

@slawekjaranowski
Copy link
Member

Waiting for #476

rather replace - not waiting - I'm right?

@andrzejj0
Copy link
Contributor Author

andrzejj0 commented Nov 19, 2022

Waiting for #476

rather replace - not waiting - I'm right?

Not anymore. I meant to wait for the outcome of the discussion there.

In other words, can be merged!

@slawekjaranowski slawekjaranowski merged commit 61c1f97 into mojohaus:master Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants