-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#704: Remove remaining ArtifactRepository leftovers + use version range for VersionsHelper where applicable #833
#704: Remove remaining ArtifactRepository leftovers + use version range for VersionsHelper where applicable #833
Conversation
0042346
to
081e19a
Compare
I've noticed that there are still some Also, Maven 3 version range resolver allows version range resolving -- using that to speed up version resolution a bit. Small refactoring/cleanup, especially in DisplayPluginUpdates. Oh and by the way -- as you can probably see, there are still some parts where we are accounting for Maven 2. Should we remove that? If so, I'll do that in another PR, because that would involve also removing some of the IT's. @slawekjaranowski please check |
e63eab1
to
1752976
Compare
versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/DisplayPluginUpdatesMojo.java
Outdated
Show resolved
Hide resolved
versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/DisplayPluginUpdatesMojo.java
Outdated
Show resolved
Hide resolved
versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/DisplayPluginUpdatesMojo.java
Outdated
Show resolved
Hide resolved
versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/DisplayPluginUpdatesMojo.java
Outdated
Show resolved
Hide resolved
24f0be6
to
a4b99bf
Compare
As advised in https://cwiki.apache.org/confluence/display/MAVEN/Plugin+migration+to+Maven3+dependencies
|
I guess I can move to PlexusJunit4TestCase in another PR. |
… version resolution
a4b99bf
to
dc19242
Compare
<prerequisites> | ||
<maven>2.0.6</maven> | ||
<maven>3.2.5</maven> | ||
</prerequisites> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prerequisites is only used for maven-plugin packaging.
version ); | ||
version ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I start thinking to introduce spotless as is done in Maven from parent poms 38 when we have such line changed 😄
Utilising the fact that we can pass the versionRange directly to
RepositorySystem.resolveVersionRange
, which should optimise the search process (possibly less lookups performed).Also, removing the unused
findLatestVersion( Artifact, VersionRange, Boolean, boolean )
method.