#858 Fix child module resolution for multi-level projects #859
Conversation
corebonts
force-pushed
the
fix858
branch
2 times, most recently
from
3e1ebcf to
9bf94d8
Compare
Modules were processed in a parallel stream which added elements to an unsynchonized LinkedHashMap / LinkedHashSet. This may resulted an incomplete set of child modules. Note that as the stream items are not processed heavily there is no or minor advantage of parallel processing.
|
Closed my own PR fixing this. @slachiewicz @slawekjaranowski could you please approve the run? Thanks |
|
I also see that I don't see a much performance benefit of used it but can cause a problem like here. Can be done is next PR 😄 |
|
Went other these during the evaluation of this one. Basically a problem occurs when there is a modification of a non-thread safe collection during stream execution. There should be no problem with the creation of a new collection, which is the case in all other places than the corrected in this PR. Having said that, replacing that with a simple stream would be a conservative take and definitely on the safe side. Experience shows that I can be wrong :) |
|
After Andrzej told me about the other problematic class, I also went through all the other usages and I can confirm that the others are ok for now. But I neither see a big performance benefit of using parallel streams. |
Child modules were processed in a parallel stream which added elements to an unsynchonized LinkedHashMap.
This may resulted an incomplete set of child modules.