-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolves #474: Add property support to UseDepVersion #878
Resolves #474: Add property support to UseDepVersion #878
Conversation
3828fd8
to
76fffa6
Compare
Manual testing... |
76fffa6
to
4ff2b58
Compare
Changed it so that it doesn't scan the whole tree if we're not processing properties. Unfortunately, there's one problem I still don't know how to tackle -- maven unnecessarily descends into children even if the plugin could have made all necessary changes starting from root level. Do you know how to change that so that Maven doesn't run recursively -- from the plugin? |
I would like to postpone this for next minor release ... in next year 😄 |
That's OK 😄 |
4ff2b58
to
ddd5888
Compare
So I guess that's a nice PR for 🎄😄 |
ddd5888
to
d803ed7
Compare
Note to self: https://maven.apache.org/developers/mojo-api-specification.html#The_Descriptor_and_Annotations Since there's time, I'll polish it a bit. |
40b4e4c
to
c2840c4
Compare
Changed to aggregate mode; this change spurred the creation of a new enhancement: #880 |
Temporarily converting to draft: let's see if I we can use maven (to do the recursion) and plugin context instead. Nope, it would make things much simpler, but -- unfortunately, the modules seem to be built in the wrong order - from top to down. |
versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/UseDepVersionMojo.java
Outdated
Show resolved
Hide resolved
- adding a new parameter, processProperties, which will also update property values if dependencies are controlled by properties - changed to aggregator mode
c2840c4
to
4d81dc7
Compare
### What changes were proposed in this pull request? This pr aims upgrade `versions-maven-plugin` to 2.15.0 ### Why are the changes needed? New version bring some improvements like: - mojohaus/versions#898 - mojohaus/versions#883 - mojohaus/versions#878 - mojohaus/versions#893 and some bug fix: - mojohaus/versions#901 - mojohaus/versions#897 - mojohaus/versions#891 The full release notes as follows: - https://github.com/mojohaus/versions/releases/tag/2.15.0 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - GA `Dependencies test` should work normally - Manually check `./dev/test-dependencies.sh --replace-manifest`, run successful Closes #40248 from LuciferYang/SPARK-42648. Authored-by: yangjie01 <[email protected]> Signed-off-by: Sean Owen <[email protected]>
The behaviour of the property is described here:
also, the behaviour is also "described" in the unit tests.
@slawekjaranowski please review
By the way, I've put 2.14.2 tentatively, but because of the nature of this PR, I'd understand if it did not fit into the release.