Resolves #888: New optional parameter to SetMojo: interpolateProperties #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Properties - allows to disable property interpolation, so that it's possible to match against raw property values as well as replace properties with interpolated values if the value is the same as the property value
|
@slawekjaranowski lots of new PRs, here's one more :) |
andrzejj0
added a commit
to andrzejj0/versions-maven-plugin
that referenced
this pull request
Dec 31, 2022
…nsMojo and UseNextReleasesMojo in case of no newer versions/releases
andrzejj0
added a commit
to andrzejj0/versions-maven-plugin
that referenced
this pull request
Dec 31, 2022
…nsMojo and UseNextReleasesMojo in case of no newer versions/releases
|
@slawekjaranowski why did you close this PR? |
Commit with closing keyword was pushed to master. |
|
Please reopen. Wrong commit message on that other PR. :| |
|
The commit message was ok: there is both an issue 889 as well as a PR 889.... |
Is that possible? |
|
So indeed wrong commit message. |
Was classed because was mentioned in merged PR
|
|
Should I create a new one? |
|
Reopened 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my take on resolving the problem which occurs when the user wants to match against a version which is the same as the interpolated property value. If this is the case, by default, the file is left unchanged, so that it continues to contain the properties.
If the new parameter is employed, it is possible to disable interpolation for such cases, but one needs to match against the raw value (e.g. use the property name, or
*), and the value will be replaced.