fix design audit #60
Open
fix design audit #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // replacing just the first instance of height, and for now we assume all heights are originally 200px | ||
| // TODO improve this logic | ||
| workingSvg = workingSvg.replace('height="200px"', 'height="' + this.height + 'px"'); | ||
| if (this.height < 200) { | ||
| workingSvg = workingSvg.replace('viewBox="0 0 100 100"', 'viewBox="0 25 100 50"') |
There was a problem hiding this comment.
hmm, is it possible to crop the svgs upstream?
| @@ -33,6 +33,8 @@ export class ResultsComponent { | |||
|
|
|||
| allRows: GeneratedStructureViewModel[] = []; | |||
| filteredRows: GeneratedStructureViewModel[] = []; | |||
| // number showed on filter button | |||
| filterLenth: number = 0; | |||
There was a problem hiding this comment.
filterLenth -> filterLength
chasing311
commented
Oct 30, 2024
| setTimeout(() => { | ||
| this.handleScroll(point.name, true); | ||
| }); | ||
| this.handleScroll(point.name, true); |
There was a problem hiding this comment.
found out don't have to do handleScroll in setTimeout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.