Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed #368 #381

Merged
merged 3 commits into from
Aug 24, 2024
Merged

Fixed #368 #381

merged 3 commits into from
Aug 24, 2024

Conversation

DenisFerrero
Copy link
Contributor

No description provided.

@icebob
Copy link
Member

icebob commented Mar 31, 2024 •
edited
Loading

It's a breaking change, because the search result will be different after this PR. Would be better to use a new param to control the case sensitivity.

@DenisFerrero
Copy link
Contributor Author

DenisFerrero commented Apr 29, 2024 •
edited
Loading

I added a new parameter called iSearch for the case-insensitive search. If both search and iSearch are passed only search will be applied, I thought that using both could cause some misunderstanding about the results so I decided to give priority to the original one. Let me know if you are okay with that, otherwise I can update the management

icebob
icebob approved these changes Aug 24, 2024
View reviewed changes
Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@icebob icebob merged commit eaa6897 into moleculerjs:master Aug 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icebob icebob icebob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DenisFerrero @icebob