Log an error if moment timezone was already loaded. #212 #219
Conversation
|
👍 |
Log an error if moment timezone was already loaded. #212
|
Can someone clarify? I'm seeing this in the following situation. We have a (parent) application A. It has dependencies B and C, each of which has moment-timezone as a dependency. I'm getting this log message, and unsure whether I need to do anything about it. It looks like the code is preventing double-loading of the moment-timezone data, so I think everything is fine. If that's the case, shouldn't the error message be something more like "Moment Timezone [loaded version] was already loaded with data from [loaded version data]. Not loading [second version] with data [second version data]. Unless [first version] is not the version you wanted to be loaded, everything is fine." Happy to issue a PR with this change (or similar) if I'm interpreting the situation correctly! |
|
Agree with @jebeck . Should we worry about this error? |
This adds an error message when loading moment-timezone twice. This addresses #212.
http://jsfiddle.net/eLh5m79c/