Allowing moment-timezone to load in a web worker thread #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As the minified version is in source control, you should run |
added 2 commits
May 8, 2014 14:07
…thread and ran grunt uglify to updated the minified file
|
Thanks, I didn't take time to notice that. The commit has been amended. |
Merged
|
Closing in favor of #92. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently tried to use moment-timezone in a web worker thread and found out it never got defined, because window is undefined in a web worker thread. To fix this I've added a case to allow moment-timezone to load in a web worker thread. I've tested this in both regular browser loading and in the web worker thread. I have not tested it with Node.js.