Added two methods incrementEach and decrementEach #2550
Conversation
|
Hello, thanks for the suggestion. For reference, this methods were added by laravel/framework#45577. Would you like to rebase the PR, add tests in |
src/Query/Builder.php
Outdated
| $this->where(function ($query) use ($column) { | ||
| $query->where($column, 'exists', false); | ||
|
|
||
| $query->orWhereNotNull($column); |
There was a problem hiding this comment.
With cumulative conditions on all fields, no field will be incremented if at least 1 of the fields is null.
We'd be wise not to set any conditions at all and let the server return an error.
add incrementEach add decrementEach
|
PR updated with tests. |
src/Query/Builder.php
Outdated
| $query->orWhereNotNull($column); | ||
| }); | ||
| $stage['$addFields'][$column] = [ | ||
| '$add' => [['$ifNull' => ['$' . $column, 0]], $amount], |
There was a problem hiding this comment.
According to the docs, there's an optimisation we can leverage in MongoDB 6.1 and later:
Starting in MongoDB 6.1 you can optimize the
$addoperation. To improve performance, group references at the end of the argument list.
| '$add' => [['$ifNull' => ['$' . $column, 0]], $amount], | |
| '$add' => [$amount, ['$ifNull' => ['$' . $column, 0]]], |
There was a problem hiding this comment.
Thanks. It's strange that the server isn't able to apply this kind of optimisation itself.
add incrementEach
add decrementEach