Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCSP-42818: wherelike and wherenotlike docs #3114

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

rustagir
Copy link
Contributor

@rustagir rustagir commented Aug 23, 2024

https://jira.mongodb.org/browse/DOCSP-42818
add documentation for whereLike() query builder method

STAGING

Checklist

  • Add tests and ensure they pass
  • Add an entry to the CHANGELOG.md file
  • Update documentation for new features

@github-actions github-actions bot added the docs label Aug 23, 2024
// begin query whereLike
$result = DB::connection('mongodb')
->table('movies')
->whereLike('title', 'Start%', true)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is causing the test to fail because the feature (#3108 ) is not merged yet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3108 is merged.

Copy link
Contributor

@jordan-smith721 jordan-smith721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 suggestion

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

The following methods provide the same functionality as using the
``like`` query operator to match patterns:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it's right above this, it might be good to link to the like operator here

// begin query whereLike
$result = DB::connection('mongodb')
->table('movies')
->whereLike('title', 'Start%', true)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3108 is merged.

@rustagir rustagir marked this pull request as ready for review August 26, 2024 17:30
@rustagir rustagir requested a review from a team as a code owner August 26, 2024 17:30
@rustagir rustagir requested a review from norareidy August 26, 2024 17:30
@rustagir rustagir merged commit 500ae9b into mongodb:4.8 Aug 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants