DOCSP-43172: Remove DatabaseTokenRepository class #3130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
requested changes
Sep 2, 2024
docs/upgrade.txt
Outdated
Comment on lines
71
to
73
| - Removes support for the ``Auth\DatabaseTokenRepository`` class. Instead, | ||
| use the ``Illuminate\Queue\Failed\DatabaseFailedJobProvider`` class and | ||
| specify a connection to MongoDB. |
There was a problem hiding this comment.
You mixed the 2 classes that are removed.
Suggested change
| - Removes support for the ``Auth\DatabaseTokenRepository`` class. Instead, | |
| use the ``Illuminate\Queue\Failed\DatabaseFailedJobProvider`` class and | |
| specify a connection to MongoDB. | |
| - Remove the ``MongoDB\Laravel\Auth\DatabaseTokenRepository`` class. Instead, | |
| use the default ``Illuminate\Auth\Passwords\DatabaseTokenRepository`` class and | |
| specify a connection to MongoDB. | |
| - Remove the ``MongoDB\Laravel\Queue\Failed\MongoFailedJobProvider`` class. Instead, | |
| use the default ``Illuminate\Queue\Failed\DatabaseFailedJobProvider`` class and | |
| specify a connection to MongoDB. |
There was a problem hiding this comment.
There's another ticket for the MongoFailedJobProvider class, but happy to include that in this PR since it's quick
rustagir
approved these changes
Sep 3, 2024
GromNaN
reviewed
Sep 4, 2024
GromNaN
approved these changes
Sep 6, 2024
…atabasetoken-class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA - https://jira.mongodb.org/browse/DOCSP-43172
This PR also covers https://jira.mongodb.org/browse/DOCSP-43166
Staging - https://preview-mongodbnorareidy.gatsbyjs.io/laravel/DOCSP-43172-stage/upgrade/#version-5.x-breaking-changes
Checklist