Fix tests on Schema index helpers #3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
schema-index-tests
branch
2 times, most recently
from
388e5fe to
31e6efe
Compare
GromNaN
force-pushed
the
schema-index-tests
branch
from
31e6efe to
58b94c1
Compare
GromNaN
commented
Jan 2, 2025
tests/SchemaTest.php
Outdated
| Schema::table('newcollection', function ($collection) { | ||
| $collection->index(['field_a' => -1, 'field_b' => 1]); | ||
| }); | ||
|
|
||
| $index = $this->getIndex('newcollection', 'field_a_-1_field_b_1'); | ||
| $index = $this->getIndex('newcollection', $indexName); | ||
| $this->assertNotNull($index); |
There was a problem hiding this comment.
Here the assertion was always true, $index was false for missing index.
There was a problem hiding this comment.
Having assertIndexExists() and assertIndexNotExists() would make the tests more readable if you wanted to go that route. I realize you can't get rid of getIndex() entirely, since some later tests expect to make assertions on the IndexInfo structure.
There was a problem hiding this comment.
Thanks for the suggestion, that's more explicit with the new assert methods.
jmikola
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find index by its actual name instead of the key fields.
Fix wrong assertions checking indexes doesn't exist with the wrong name.