Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor psalm and phpcs workflows to get static names #1115

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Jun 22, 2023

Using a matrix strategy results in changing names whenever we change the driver or PHP version, requiring an update to protected branch settings. Moving this configuration to env variables prevents this issue.

Using a matrix strategy results in changing names whenever we change the driver or PHP version, requiring an update to protected branch settings. Moving this configuration to env variables prevents this issue.
@alcaeus alcaeus requested a review from GromNaN June 22, 2023 10:32
@alcaeus alcaeus self-assigned this Jun 22, 2023
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Indeed it was a 1x1 matrix 🥲.

@GromNaN GromNaN merged commit d4cdf05 into mongodb:master Jun 22, 2023
@alcaeus alcaeus deleted the change-build-names branch June 22, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants