fix(NODE-5289): prevent scram auth from throwing TypeError if saslprep is not a function #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baileympearson
force-pushed
the
NODE-5289-handle-null-saslprep
branch
from
b1e90dc to
d6899a3
Compare
baileympearson
changed the title
nbbeeken
requested changes
Jun 15, 2023
nbbeeken
added
the
Primary Review
nbbeeken
requested changes
Jun 16, 2023
nbbeeken
requested changes
Jun 16, 2023
nbbeeken
requested changes
Jun 16, 2023
nbbeeken
requested changes
Jun 16, 2023
nbbeeken
added
Team Review
Co-authored-by: Neal Beeken <[email protected]>
nbbeeken
approved these changes
Jun 16, 2023
baileympearson
added a commit
that referenced
this pull request
Jun 16, 2023
…p is not a function (#3727)
baileympearson
added a commit
that referenced
this pull request
Jun 16, 2023
…p is not a function (#3727)
Merged
5 tasks
malikj2000
pushed a commit
that referenced
this pull request
Jun 29, 2023
…p is not a function (#3727)
This was referenced Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
saslprep"is not a function" fix for bundled deploymentssaslprepis an optional dependency used to perform Stringprep Profile for User Names and Passwords for SCRAM-SHA-256 authentication. Thesaslpreplibrary breaks when it is bundled, causing the driver to throwTypeErrors.This release includes a fix that prevents the driver throwing
TypeErrors when attempting to usesaslprepin bundled environments.Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript