-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(NODE-5243): add change stream split event #3745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment, LGTM
// Collect two events from _S_. | ||
const eventOne = await changeStream.next(); | ||
const eventTwo = await changeStream.next(); | ||
await changeStream.close(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move the close logic here into the afterEach
hook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Description
Adds support for change stream split events.
What is changing?
ChangeStreamSplitEvent
type.splitEvent
to the change stream common document type.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-5243
Release Highlight
Support for change stream split events
When change stream documents exceed the max BSON size limit of 16MB, they can be split into multiple fragments in order to not error when sending events over the wire. In order to enable this functionality, the collection must be created with
changeStreamPreAndPostImages
enabled and the change stream itself must include an$changeStreamSplitLargeEvent
aggregation stage. This feature requires a minimum server version of 7.0.0.Example:
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript