Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use also code in shipping method directory to avoid issue if same name #19

Conversation

maximehuran
Copy link
Member

No description provided.

@maximehuran maximehuran requested a review from lanfisis January 7, 2022 14:54
@madamebiz madamebiz added quick win Easy to pick, everybody will be happy. Status: needs review Needs review labels Jan 7, 2022
@maximehuran
Copy link
Member Author

I ignored schema tests in Makefile because we have an issue with the test application migration and the sylius gateway config schema : Sylius/Sylius#13214 (comment)

@maximehuran maximehuran merged commit 52088b2 into monsieurbiz:master Jan 7, 2022
@maximehuran maximehuran deleted the feature/correct-shipping-methods-list branch January 7, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick win Easy to pick, everybody will be happy. Status: needs review Needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants