try warning #1
Open
try warning #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noboru-i
force-pushed
the
sample-warnings
branch
from
8e684f3 to
f312558
Compare
| @@ -15,7 +15,7 @@ class MainActivity : AppCompatActivity() { | |||
| setContentView(R.layout.activity_main) | |||
| setSupportActionBar(toolbar) | |||
|
|
|||
| fab.setOnClickListener { view -> | |||
| fab.setOnClickListener {view -> | |||
There was a problem hiding this comment.
| Missing spacing after “{“ |
| @@ -27,6 +27,7 @@ class MainActivity : AppCompatActivity() { | |||
| return true | |||
| } | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
| Needless blank line(s) |
| @@ -2,7 +2,7 @@ | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | |||
| package="com.monstar_lab.sample.android.kotlin"> | |||
|
|
|||
| <application | |||
| <application | |||
There was a problem hiding this comment.
On SDK version 23 and up, your app data will be automatically backed up and restored on app install. Consider adding the attribute android:fullBackupContent to specify an @xml resource which configures which files to backup. More info: https://developer.android.com/training/backup/autosyncapi.html |
| @@ -2,7 +2,7 @@ | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | |||
| package="com.monstar_lab.sample.android.kotlin"> | |||
|
|
|||
| <application | |||
| <application | |||
There was a problem hiding this comment.
| App is not indexable by Google Search; consider adding at least one Activity with an ACTION-VIEW intent filter. See issue explanation for more details. |
noboru-i
force-pushed
the
sample-warnings
branch
from
10e395f to
0af9a7a
Compare
| @@ -36,4 +37,7 @@ class MainActivity : AppCompatActivity() { | |||
| else -> super.onOptionsItemSelected(item) | |||
| } | |||
| } | |||
|
|
|||
| public fun aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa() { | |||
There was a problem hiding this comment.
| Exceeded max line length (100) |
| @@ -36,4 +37,7 @@ class MainActivity : AppCompatActivity() { | |||
| else -> super.onOptionsItemSelected(item) | |||
| } | |||
| } | |||
|
|
|||
| public fun aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa() { | |||
There was a problem hiding this comment.
| Line detected that is longer than the defined maximum line length in the code style. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.