try warning #1
Open
try warning #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noboru-i
force-pushed
the
sample-warnings
branch
from
628be36 to
6d76629
Compare
noboru-i
force-pushed
the
sample-warnings
branch
from
6d76629 to
dfcc5b6
Compare
noboru-i
force-pushed
the
master
branch
2 times, most recently
from
5ef0af6 to
419b903
Compare
noboru-i
force-pushed
the
sample-warnings
branch
from
dfcc5b6 to
f118516
Compare
| @@ -13,7 +13,7 @@ import RxSwift | |||
|
|
|||
| class ViewController: UIViewController { | |||
|
|
|||
| override func viewDidLoad() { | |||
| override func viewDidLoad(){ | |||
There was a problem hiding this comment.
| Opening braces should be preceded by a single space and on the same line as the declaration. |
| @@ -27,6 +27,8 @@ class ViewController: UIViewController { | |||
| SVProgressHUD.show(withStatus: "Sample iOS app") | |||
| } | |||
| }) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
| Limit vertical whitespace to a single empty line. Currently 2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.