Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Rust version to 1.81.0 #691

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Bump Rust version to 1.81.0 #691

merged 5 commits into from
Oct 4, 2024

Conversation

nanocryk
Copy link
Contributor

Using same version as paritytech/polkadot-sdk#5676

We're currently on 1.78.0, and I'd like to use this feature introduced in 1.79.0, which will allow to shorten a lot our where-clauses with trait aliases that can imply/infer associated types bounds.

@nanocryk nanocryk added a0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit labels Sep 25, 2024
Copy link
Contributor

@tmpolaczyk tmpolaczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, merge back master please

@nanocryk nanocryk force-pushed the jeremy-bump-rust-version branch from c6279b0 to 0c457c3 Compare October 2, 2024 09:45
@nanocryk
Copy link
Contributor Author

nanocryk commented Oct 4, 2024

We seem to hit the same issue as described in this Rust issue, which seems to be a compiler regression. Until it is fixed, we can make progress by adding --exclude tc-consensus to cargo test inside the coverage CI job.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

Coverage Report

(master)

@@                     Coverage Diff                      @@
##           master   jeremy-bump-rust-version      +/-   ##
============================================================
- Coverage   66.82%                     65.29%   -1.53%     
- Files         297                        296       -1     
- Lines       51894                      51468     -426     
============================================================
- Hits        34677                      33605    -1072     
+ Misses      17217                      17863     +646     
Files Changed Coverage
/client/consensus/src/collators/lookahead.rs 0.00% (-77.98%) 🔽
/client/consensus/src/collators.rs 0.00% (-85.82%) 🔽
/client/consensus/src/consensus_orchestrator.rs 0.00% (-100.00%) 🔽
/client/consensus/src/lib.rs 13.45% (-17.64%) 🔽
/client/manual-xcm/src/lib.rs 24.05% (-16.38%) 🔽
/client/service-container-chain/src/data_preservers.rs 80.40% (-0.08%) 🔽
/client/service-container-chain/src/monitor.rs 39.67% (+2.80%) 🔼
/client/service-container-chain/src/service.rs 6.70% (-0.48%) 🔽
/client/service-container-chain/src/spawner.rs 44.66% (+0.17%) 🔼
/container-chains/nodes/frontier/src/command.rs 25.56% (-9.48%) 🔽
/container-chains/nodes/frontier/src/rpc/finality.rs 95.92% (-4.08%) 🔽
/container-chains/nodes/frontier/src/rpc/mod.rs 89.77% (-0.88%) 🔽
/container-chains/nodes/frontier/src/service.rs 80.06% (+0.49%) 🔼
/container-chains/nodes/simple/src/command.rs 18.81% (-6.14%) 🔽
/container-chains/nodes/simple/src/rpc.rs 95.35% (-0.21%) 🔽
/container-chains/nodes/simple/src/service.rs 87.68% (+1.16%) 🔼
/container-chains/runtime-templates/frontier/build.rs 0.00% (-100.00%) 🔽
/container-chains/runtime-templates/simple/build.rs 0.00% (-100.00%) 🔽
/node/src/command.rs 27.46% (-6.47%) 🔽
/node/src/rpc.rs 97.92% (-0.08%) 🔽
/node/src/service.rs 15.65% (+0.34%) 🔼
/pallets/author-noting/src/lib.rs 87.50% (-0.26%) 🔽
/pallets/configuration/src/lib.rs 84.94% (+0.38%) 🔼
/pallets/data-preservers/src/lib.rs 85.30% (+0.35%) 🔼
/pallets/invulnerables/src/lib.rs 86.49% (+0.90%) 🔼
/pallets/pooled-staking/src/lib.rs 55.17% (+0.38%) 🔼
/pallets/registrar/src/lib.rs 88.54% (+0.14%) 🔼
/pallets/services-payment/src/lib.rs 90.27% (+0.30%) 🔼
/pallets/stream-payment/src/lib.rs 88.57% (+0.21%) 🔼
/primitives/traits/src/alias.rs 84.62% (+62.40%) 🔼
/primitives/traits/src/lib.rs 65.49% (-6.19%) 🔽
/primitives/xcm-core-buyer/src/lib.rs 38.30% (-48.93%) 🔽
/runtime/common/src/migrations.rs 89.36% (-0.44%) 🔽
/runtime/dancebox/build.rs 0.00% (-100.00%) 🔽
/runtime/dancebox/src/tests/common/mod.rs 98.64% (-0.01%) 🔽
/runtime/dancebox/src/tests/common/xcm/core_buyer_common.rs 87.04% (+0.59%) 🔼
/runtime/flashbox/build.rs 0.00% (-100.00%) 🔽
/solo-chains/client/cli/src/command.rs 43.07% (-1.21%) 🔽
/solo-chains/node/tanssi-relay-service/src/dev_service.rs 88.19% (+0.01%) 🔼
/solo-chains/runtime/dancelight/build.rs 0.00% (-100.00%) 🔽
/solo-chains/runtime/dancelight/src/genesis_config_presets.rs 57.40% (+0.17%) 🔼
/solo-chains/runtime/dancelight/src/governance/fellowship.rs 17.65% (-71.99%) 🔽
/solo-chains/runtime/dancelight/src/governance/origins.rs 4.65% (+2.32%) 🔼
/solo-chains/runtime/dancelight/src/lib.rs 67.36% (+0.69%) 🔼
/solo-chains/runtime/dancelight/src/tests/common/mod.rs 96.39% (-0.03%) 🔽
/solo-chains/runtime/dancelight/src/validator_manager.rs 51.67% (+1.67%) 🔼

Coverage generated Fri Oct 4 08:43:54 UTC 2024

@nanocryk nanocryk merged commit ca359f7 into master Oct 4, 2024
39 checks passed
@nanocryk nanocryk deleted the jeremy-bump-rust-version branch October 4, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a0-pleasereview Pull request needs code review. B0-silent Changes should not be mentioned in any release notes D3-trivial PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants