fix/deployhook-function-should-not-be-static

moreamazingnick · Aug 24, 2023 · b6e48d5 · b6e48d5
1 parent 5ca2d36
commit b6e48d5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/library/Director/Core/CoreApi.php b/library/Director/Core/CoreApi.php
@@ -852,7 +852,7 @@ public function dumpConfig(IcingaConfig $config, Db $db, $packageName = null)
         $hooks = Hook::all('director/Deployment');
         foreach ($hooks as $hook) {
             $hook->beforeDeploy($deployment);
-            $hook::beforeDump($files);
+            $files = $hook->beforeDump($files);
         }
 
         $this->assertPackageExists($packageName);

diff --git a/library/Director/Hook/DeploymentHook.php b/library/Director/Hook/DeploymentHook.php
@@ -16,14 +16,16 @@ public function beforeDeploy(DirectorDeploymentLog $deployment)
     {
     }
 
+
     /**
-     * Please override this method if you want to change the deployed files
-     * in any way
      *
-     * @param array $files
+     * Please override this method if you want to change the deployed files before writing them to disk
+     *
+     * @param $files
+     * @return array with $files
      */
-    public static function beforeDump($files){
-
+    public function beforeDump($files){
+        return $files;
     }
 
     /**