Merge branch 'main' into ribbon-menu

morganstanley · Feb 23, 2023 · 4584fbf · 4584fbf
2 parents a6c8acd + 08c19f8
commit 4584fbf
Show file tree

Hide file tree

Showing 142 changed files with 16,140 additions and 2,621 deletions.
diff --git a/Tryouts/Core/Abstractions/MorganStanley.ComposeUI.Tryouts.Core.Abstractions.csproj b/Tryouts/Core/Abstractions/MorganStanley.ComposeUI.Tryouts.Core.Abstractions.csproj
@@ -18,20 +18,4 @@ See the License for the specific language governing permissions and limitations
     <Nullable>enable</Nullable>
   </PropertyGroup>
 
-  <ItemGroup>
-    <Compile Remove="ITimeService.cs" />
-  </ItemGroup>
-
-  <ItemGroup>
-    <PackageReference Include="Google.Protobuf" Version="3.21.4" />
-    <PackageReference Include="Grpc.Tools" Version="2.47.0">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
-  </ItemGroup>
-
-  <ItemGroup>
-    <ProjectReference Include="..\..\..\src\Core\Abstractions\MorganStanley.ComposeUI.Core.Abstractions.csproj" />
-  </ItemGroup>
-
 </Project>
diff --git a/Tryouts/Core/BasicModels/MorganStanley.ComposeUI.Tryouts.Core.BasicModels.csproj b/Tryouts/Core/BasicModels/MorganStanley.ComposeUI.Tryouts.Core.BasicModels.csproj
diff --git a/Tryouts/Core/BasicModels/README.md b/Tryouts/Core/BasicModels/README.md
diff --git a/Tryouts/Core/README.md b/Tryouts/Core/README.md
@@ -8,6 +8,5 @@ Core folder contain non-visual multiplatform code that can be re-used between va
 There are following projects under Core:
 
 1. Abstractions - containing interfaces and simple classes/structures that they depend on. These interfaces are being implemented primarily by the dynamically loaded plugins and are used for interactions between the varoius plugins, and the shell.
-2. BasicModels - contain the non-visual View Model functionality that can be used throughout the application.
-3. Utilities - basic non-visual utilities, e.g. classes containing extension methods, generic base classes and other functionality that can be used everywhere else.
+2. Utilities - basic non-visual utilities, e.g. classes containing extension methods, generic base classes and other functionality that can be used everywhere else.
 
diff --git a/Tryouts/Core/Utilities/MorganStanley.ComposeUI.Tryouts.Core.Utilities.csproj b/Tryouts/Core/Utilities/MorganStanley.ComposeUI.Tryouts.Core.Utilities.csproj
@@ -16,8 +16,4 @@ See the License for the specific language governing permissions and limitations
     <TargetFramework>net6.0</TargetFramework>
   </PropertyGroup>
 
-  <ItemGroup>
-    <ProjectReference Include="..\..\..\src\Core\Utilities\MorganStanley.ComposeUI.Core.Utilities.csproj" />
-  </ItemGroup>
-
 </Project>
diff --git a/Tryouts/Messaging/Client/Client/Abstractions/IConnection.cs b/Tryouts/Messaging/Client/Client/Abstractions/IConnection.cs
@@ -32,12 +32,16 @@ internal interface IConnection : IAsyncDisposable
     /// <param name="message"></param>
     /// <param name="cancellationToken"></param>
     /// <returns></returns>
+    /// <exception cref="MessageRouterException">With name <see cref="MessageRouterErrors.ConnectionClosed"/> if the connection was closed by either party while sending the request</exception>
+    /// <exception cref="MessageRouterException">With name <see cref="MessageRouterErrors.ConnectionAborted"/> if the connection was closed due to an unexpected error</exception>
     ValueTask SendAsync(Message message, CancellationToken cancellationToken = default);
 
     /// <summary>
     /// Receives the next message from the server.
     /// </summary>
     /// <param name="cancellationToken"></param>
     /// <returns></returns>
+    /// <exception cref="MessageRouterException">With name <see cref="MessageRouterErrors.ConnectionClosed"/> if the connection was closed by either party while sending the request</exception>
+    /// <exception cref="MessageRouterException">With name <see cref="MessageRouterErrors.ConnectionAborted"/> if the connection was closed due to an unexpected error</exception>
     ValueTask<Message> ReceiveAsync(CancellationToken cancellationToken = default);
 }