- Rename IModuleLoader.RequestStartProcess/RequestStopProcess to Requ…

…estStart/RequestStop

- Rename StartupRequest to StartRequest
- Change StartupContext's object holder to ImmutableList

src/module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/IModuleLoader.cs

@@ -14,9 +14,9 @@ namespace MorganStanley.ComposeUI.ModuleLoader;
 
 public interface IModuleLoader
 {
-    void RequestStartProcess(StartupRequest startupRequest);
+    void RequestStart(StartRequest startupRequest);
 
-    void RequestStopProcess(StopRequest stopRequest);
+    void RequestStop(StopRequest stopRequest);
 
     IObservable<LifetimeEvent> LifetimeEvents { get; }
 }

src/module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/StartupRequest.cs → src/module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/StartRequest.cs

@@ -12,15 +12,15 @@
 
 namespace MorganStanley.ComposeUI.ModuleLoader;
 
-public sealed class StartupRequest
+public sealed class StartRequest
 {
-    public StartupRequest(string name)
+    public StartRequest(string moduleName)
     {
-        Name = name;
+        ModuleName = moduleName;
         InstanceId = Guid.NewGuid();
     }
 
     public Guid InstanceId { get; }
 
-    public string Name { get; }
+    public string ModuleName { get; }
 }

src/module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/StartupContext.cs

@@ -11,27 +11,28 @@
 // and limitations under the License.
 
 using System.Collections.Concurrent;
+using System.Collections.Immutable;
 
 namespace MorganStanley.ComposeUI.ModuleLoader;
 
 public sealed class StartupContext
 {
-    private readonly ConcurrentDictionary<Type, List<object>> _values = new ConcurrentDictionary<Type, List<object>>();
+    private readonly ConcurrentDictionary<Type, ImmutableList<object>> _values = new();
 
-    public StartupContext(StartupRequest startupRequest)
+    public StartupContext(StartRequest startupRequest)
     {
         StartupRequest = startupRequest;
     }
 
-    public StartupRequest StartupRequest { get; }
+    public StartRequest StartupRequest { get; }
 
     public void Add<T>(T value)
     {
         ArgumentNullException.ThrowIfNull(value, nameof(value));
 
         _values.AddOrUpdate(typeof(T),
-            new List<object> { value },
-            (type, list) => { list.Add(value); return list; });
+            (type) => { var list = ImmutableList<object>.Empty.Add(value); return list; },
+            (type, list) => { var newList = list.Add(value); return newList; });
     }
 
     public IEnumerable<T> Get<T>()

src/module-loader/dotnet/tests/MorganStanley.ComposeUI.ModuleLoader.Abstractions.Tests/StartupContextTests.cs

@@ -23,7 +23,7 @@ public void WhenAdd_AddedValuesCanBeRetrieved()
             new MyContextInfo { Name = "Test2" }
         };
 
-        StartupContext context = new StartupContext(new StartupRequest("test"));
+        StartupContext context = new StartupContext(new StartRequest("test"));
         context.Add(expected[0]);
         context.Add(expected[1]);
 
@@ -35,14 +35,14 @@ public void WhenAdd_AddedValuesCanBeRetrieved()
     [Fact]
     public void GivenNullArgument_WhenAdd_ThrowsArgumentNullException()
     {
-        StartupContext context = new StartupContext(new StartupRequest("test"));
+        StartupContext context = new StartupContext(new StartRequest("test"));
         Assert.Throws<ArgumentNullException>(() => context.Add<object>(null!));
     }
 
     [Fact]
     public void WhenGet_UnknownType_EmptyEnumerableIsReturned()
     {
-        StartupContext context = new StartupContext(new StartupRequest("test"));
+        StartupContext context = new StartupContext(new StartRequest("test"));
         var result = context.Get<MyContextInfo>();
 
         Assert.Equal(Enumerable.Empty<MyContextInfo>(), result);