Throwing Exception from Utility Function

morganstanley · Jul 4, 2023 · 96df7c8 · 96df7c8
1 parent 5196196
commit 96df7c8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 19 deletions.
diff --git a/src/shell/dotnet/Shell/Utilities/ResourceReader.cs b/src/shell/dotnet/Shell/Utilities/ResourceReader.cs
@@ -24,24 +24,21 @@ namespace Shell.Utilities
 {
     public static class ResourceReader
     {
-        public static string ReadResource(string name)
+        public static string ReadResource(string name) 
         {
             var assembly = Assembly.GetExecutingAssembly();
             string resourcePath = name;
-            try
+
+            var stream = assembly.GetManifestResourceStream(resourcePath);
+
+            if (stream == null)
             {
-                using (var stream = assembly.GetManifestResourceStream(resourcePath))
-                using (var reader = new StreamReader(stream))
-                {
-                    return reader.ReadToEnd();
-                }
+                throw new InvalidOperationException("Resource not found");
             }
-            catch
+            using (var reader = new StreamReader(stream))
             {
-                return null;
+                return reader.ReadToEnd();
             }
-
-
         }
     }
 }
diff --git a/src/shell/dotnet/tests/Shell.Tests/ResourceReaderTests.cs b/src/shell/dotnet/tests/Shell.Tests/ResourceReaderTests.cs
@@ -25,14 +25,6 @@ namespace ShellTests
 {
     public class ReadResourceTests
     {
-        [Fact]
-        public void ResourceNotAvailable()
-        {
-            var resource = ResourceReader.ReadResource("NotAvailableResource");
-
-            Assert.Null(resource);
-        }
-
         [Fact]
         public void ResourceCanBeRead()
         {