Simplify Processing Arguments in Node.js CLI (#178)

* Simplify processArgs() * rename Launcher * Rename WindowConfig * Rename BrowserWindow
morganstanley · Mar 14, 2023 · f438155 · f438155
1 parent cd9c7a3
commit f438155
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 21 deletions.
diff --git a/...poseui-node-launcher/src/BrowserWindow.ts → ...poseui-node-launcher/src/browserWindow.ts b/...poseui-node-launcher/src/BrowserWindow.ts → ...poseui-node-launcher/src/browserWindow.ts
@@ -1,4 +1,4 @@
-import { WindowConfig } from './WindowConfig';
+import { WindowConfig } from './windowConfig';
 import { Launcher } from './launcher.js';
 
 export class BrowserWindow {

diff --git a/src/shell/js/composeui-node-launcher/src/index.ts b/src/shell/js/composeui-node-launcher/src/index.ts
@@ -1,5 +1,5 @@
-export { BrowserWindow } from './BrowserWindow.js';
+export { BrowserWindow } from './browserWindow.js';
 export { Launcher } from './launcher.js';
-export { WindowConfig } from './WindowConfig.js';
+export { WindowConfig } from './windowConfig.js';
 export * from './cli/cli.js';
 export { executeScriptFile } from './cli/executeScrtiptFile.js';
diff --git a/src/shell/js/composeui-node-launcher/src/launcher.spec.ts b/src/shell/js/composeui-node-launcher/src/launcher.spec.ts
@@ -1,5 +1,5 @@
 import { Launcher } from './launcher';
-import { WindowConfig } from './WindowConfig';
+import { WindowConfig } from './windowConfig';
 
 describe('Launcher', () => {
   let testWindowConfig: WindowConfig;

diff --git a/...s/composeui-node-launcher/src/Launcher.ts → ...s/composeui-node-launcher/src/launcher.ts b/...s/composeui-node-launcher/src/Launcher.ts → ...s/composeui-node-launcher/src/launcher.ts
@@ -1,27 +1,13 @@
 import { execFile } from 'child_process';
-import { WindowConfig } from './WindowConfig';
+import { WindowConfig } from './windowConfig';
 
 export class Launcher {
     private processArgs(config?: WindowConfig) {
         let argsArray = [];
         if (config) {
-            if (config?.title) {
-                argsArray.push(`--title=${config.title}`);
+            for (const [key, value] of Object.entries(config)) {
+                argsArray.push(`--${key}=${value}`);
             }
-            if(config?.icon) {
-                argsArray.push(`--icon=${config.icon}`)
-            }
-            if (config?.url) {
-                argsArray.push(`--url=${config.url}`);
-            }
-
-            if (config?.width) {
-                argsArray.push(`--width=${config.width}`);
-            }
-
-            if (config?.height) {
-                argsArray.push(`--height=${config.height}`);
-            }            
         }
 
         return argsArray;

diff --git a/...mposeui-node-launcher/src/WindowConfig.ts → ...mposeui-node-launcher/src/windowConfig.ts b/...mposeui-node-launcher/src/WindowConfig.ts → ...mposeui-node-launcher/src/windowConfig.ts