New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shell creates a dynamic window with a webview2 control #101

Merged

kruplm merged 49 commits into morganstanley:main from kruplm:webview2-control

Dec 19, 2022

Contributor

kruplm commented Oct 20, 2022

No description provided.


          Shell creates a dynamic window with a webview2 control

80afd1e

ztanczos reviewed

View reviewed changes

Tryouts/Prototypes/Shell/WebContent.xaml.cs Outdated Show resolved Hide resolved

ztanczos reviewed

View reviewed changes

Tryouts/Prototypes/Shell/MainWindow.xaml.cs Outdated Show resolved Hide resolved

ztanczos reviewed

View reviewed changes

Tryouts/Prototypes/Shell/MainWindow.xaml.cs Outdated Show resolved Hide resolved

ztanczos reviewed

View reviewed changes

Tryouts/Prototypes/Shell/WebContent.xaml.cs Outdated Show resolved Hide resolved

ztanczos reviewed

View reviewed changes

Tryouts/Prototypes/Shell/WebContent.xaml.cs Outdated Show resolved Hide resolved

kruplm added 12 commits

October 28, 2022 17:51


          Eliminate the creation of unnecessary Window objects

65bc499


          Set up layout in xaml

65e926a


          Opening WebContent Window with a button.

ae57ae4


          Remove unnecessary Show() event.

de92fd4


          Removed unnecessary wrapper function

c859caf


          Opening multiple child windows

0df7f05


          Closing child windows upon app closing

91c2538


          Rearange layout

2b44ba9


          Clean-up code

75eed79


          Add license headers


          Remove empty lines

4dfa1b1


          URL from manifest file

6e6c9bb

BalassaMarton previously approved these changes

View reviewed changes


          Multiple child windows from manifest file

1fb9852

kruplm dismissed BalassaMarton’s stale review via

1fb9852

November 23, 2022 08:48

kruplm added 4 commits

November 23, 2022 09:54


          Move to Manifest namespace

5628ee1


          Pass manifest filepath as a parameter

3ef7103


          Add license headers

ae08744


          Simplify ForEach loop

5c25c44

Contributor

ZKRobi commented Nov 24, 2022

Just a reminder, please squash commits before merging the PR :)

kruplm added 3 commits

December 5, 2022 15:17


          Refine Child Window handling

3acc7bb


          webContentList is internal


          Upgrade WebView2

2d72362

kruplm marked this pull request as ready for review

December 13, 2022 10:44

kruplm added 13 commits

December 13, 2022 11:45


          Rearange layout

3bb4e42


          Clean-up code

4344c05


          Add license headers

bc2fe15


          Remove empty lines

0617e14


          URL from manifest file

0e2ab30


          Multiple child windows from manifest file

7becbef


          Move to Manifest namespace

788a6ab


          Pass manifest filepath as a parameter

2659d53


          Add license headers

457f55f


          Simplify ForEach loop

2291b12


          Refine Child Window handling

07950da


          webContentList is internal

679affd


          Upgrade WebView2

93a3f7e

kruplm force-pushed the webview2-control branch from 2d72362 to 93a3f7e Compare

December 13, 2022 10:45

BalassaMarton reviewed

View reviewed changes

Tryouts/Prototypes/Shell/MainWindow.xaml.cs Outdated Show resolved Hide resolved

Tryouts/Prototypes/Shell/MainWindow.xaml.cs Outdated Show resolved Hide resolved

Tryouts/Prototypes/Shell/WebContent.xaml.cs Outdated Show resolved Hide resolved

Tryouts/Prototypes/Shell/WebContent.xaml.cs Outdated Show resolved Hide resolved

Tryouts/Prototypes/Shell/WebContent.xaml.cs Outdated Show resolved Hide resolved

Tryouts/Prototypes/Shell/MainWindow.xaml.cs Outdated Show resolved Hide resolved

ztanczos reviewed

View reviewed changes

Tryouts/Prototypes/Shell/Manifest/ManifestParser.cs Outdated Show resolved Hide resolved

ztanczos reviewed

View reviewed changes

Tryouts/Prototypes/Shell/Manifest/ManifestParser.cs Outdated Show resolved Hide resolved

ztanczos reviewed

View reviewed changes

Tryouts/Prototypes/Shell/Manifest/ManifestParser.cs Outdated Show resolved Hide resolved

ztanczos reviewed

View reviewed changes

Tryouts/Prototypes/Shell/MainWindow.xaml.cs Outdated Show resolved Hide resolved

BalassaMarton reviewed

View reviewed changes

Tryouts/Prototypes/Shell/Manifest/ManifestParser.cs Outdated Show resolved Hide resolved

Tryouts/Prototypes/Shell/Manifest/ModuleModel.cs Show resolved Hide resolved

kruplm added 6 commits

December 15, 2022 12:37


          Clean-up code

667c289


          Resolve Merge Conflict

53a4ed2


          Simplify manifest parsing

171456c


          Clean-up

2f465f7


          Buttons are dynamic

6418dc0


          Url through DataContext

826b31f

kruplm added this to the Compose as a web container milestone


          Merge branch 'main' into webview2-control

694c268

BalassaMarton approved these changes

View reviewed changes

kruplm merged commit 809dca1 into morganstanley:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet