Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node launcher #134

Merged
merged 30 commits into from
Feb 17, 2023
Merged

Node launcher #134

merged 30 commits into from
Feb 17, 2023

Conversation

kruplm
Copy link
Contributor

@kruplm kruplm commented Jan 31, 2023

Story: "As a frontend developer I can configure the height, width, title and the URL of a browser window from my JavaScript application."

  • the shell can be launched from Node.JS as well.
  • width, height and title of the window can be specified.
  • An url can be passed via configuration or by the LoadUrl() function
  • The default config loading (with pre-existing manifest file) still works the same way - so that our future Universal hosting goals can be achieved.
  • As part of this PR the manifest file parsing was also improved.

@kruplm kruplm added this to the Compose as a web container milestone Jan 31, 2023
Tryouts/Prototypes/Shell/Manifest/ManifestParser.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/Manifest/ManifestParser.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/MainWindow.xaml.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/MainWindow.xaml.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/Node-launcher/Lib/src/Launcher.ts Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/MainWindow.xaml.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/MainWindow.xaml.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/MainWindow.xaml.cs Outdated Show resolved Hide resolved
@kruplm kruplm marked this pull request as ready for review February 13, 2023 10:58
@kruplm kruplm requested a review from a team February 13, 2023 10:58
Tryouts/Prototypes/Shell/App.xaml.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/MainWebWindow.xaml.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/MainWebWindow.xaml.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/MainWebWindow.xaml.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/MainWebWindow.xaml.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/Node-launcher/Lib/src/Launcher.ts Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/Node-launcher/Lib/src/Launcher.ts Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/Node-launcher/Lib/src/Launcher.ts Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/App.xaml.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/MainWebWindow.xaml.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/CommandLineArgumentsParser.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/CommandLineArgumentsParser.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/CommandLineArgumentsParser.cs Outdated Show resolved Hide resolved
BalassaMarton
BalassaMarton previously approved these changes Feb 16, 2023
Tryouts/Prototypes/Shell/MainWebWindowOptions.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/MainWebWindowOptionsParser.cs Outdated Show resolved Hide resolved
Tryouts/Prototypes/Shell/MainWindow.xaml.cs Show resolved Hide resolved
Tryouts/Prototypes/Shell/MainWebWindowOptions.cs Outdated Show resolved Hide resolved
@kruplm kruplm merged commit 7c39677 into morganstanley:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants