-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node launcher #134
Merged
Merged
Node launcher #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalassaMarton
suggested changes
Feb 9, 2023
Tryouts/Prototypes/Shell/Node-launcher/Lib/src/BrowserWindow.ts
Outdated
Show resolved
Hide resolved
ztanczos
reviewed
Feb 9, 2023
BalassaMarton
suggested changes
Feb 13, 2023
ztanczos
reviewed
Feb 13, 2023
ztanczos
reviewed
Feb 13, 2023
ztanczos
reviewed
Feb 14, 2023
kruplm
force-pushed
the
node-launcher
branch
from
February 15, 2023 13:17
9592644
to
9444a0c
Compare
BalassaMarton
previously approved these changes
Feb 16, 2023
kruplm
force-pushed
the
node-launcher
branch
from
February 17, 2023 10:53
51140ed
to
e3ddb68
Compare
BalassaMarton
suggested changes
Feb 17, 2023
BalassaMarton
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: "As a frontend developer I can configure the height, width, title and the URL of a browser window from my JavaScript application."