Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple web windows #155

Merged
merged 4 commits into from
Feb 21, 2023
Merged

Support multiple web windows #155

merged 4 commits into from
Feb 21, 2023

Conversation

BalassaMarton
Copy link
Contributor

Handle window.open() in web pages and scripts.

Working

  • New window creation
  • Multi-window behavior when started as a browser window

TODO

  • Child windows (not possible from main node process without messaging)

@BalassaMarton BalassaMarton requested a review from a team February 20, 2023 16:24
@BalassaMarton BalassaMarton changed the title Webview newwindow Support multiple web windows Feb 20, 2023
@BalassaMarton BalassaMarton merged commit fee34a5 into morganstanley:main Feb 21, 2023
@BalassaMarton BalassaMarton deleted the webview-newwindow branch February 22, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ztanczos ztanczos ztanczos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BalassaMarton @ztanczos