Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComposeUI Node.js CLI #156

Merged
merged 6 commits into from
Feb 22, 2023
Merged

ComposeUI Node.js CLI #156

merged 6 commits into from
Feb 22, 2023

Conversation

kruplm
Copy link
Contributor

@kruplm kruplm commented Feb 21, 2023 •
edited
Loading

  • ComposeUI CLI makes possible for javascript developers to execute their applications like composeui-cli myapp.js as opposed to node myapp.js or node node_modules@morgan-stanley-compose-node-launcher\lib\cli\cli.js myapp.js
  • Documentation is also included

@kruplm kruplm requested a review from a team February 21, 2023 13:54
@BalassaMarton
Copy link
Contributor

BalassaMarton commented Feb 21, 2023 •
edited
Loading

I'm strongly in favor of writing the CLI in .NET instead. We have more .NET expertise on the team, and the workflow is just much simpler and more robust.

OK so this was a misunderstanding on my side, this cli is exclusively for running node apps.

@kruplm kruplm changed the title composeui-cli composeui Node.js CLI Feb 21, 2023
@kruplm kruplm changed the title composeui Node.js CLI Composeui Node.js CLI Feb 21, 2023
@kruplm kruplm changed the title Composeui Node.js CLI ComposeUI Node.js CLI Feb 22, 2023
@kruplm kruplm merged commit ea5e162 into morganstanley:main Feb 22, 2023
@kruplm kruplm added this to the Compose as a web container milestone Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalassaMarton BalassaMarton BalassaMarton approved these changes

@ztanczos ztanczos ztanczos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Compose as a web container
Development

Successfully merging this pull request may close these issues.
3 participants
@kruplm @BalassaMarton @ztanczos