Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming conventions for JavaScript packages #159

Merged
merged 4 commits into from
Feb 22, 2023
Merged

Naming conventions for JavaScript packages #159

merged 4 commits into from
Feb 22, 2023

Conversation

kruplm
Copy link
Contributor

@kruplm kruplm commented Feb 22, 2023 •
edited
Loading

  • renamed example-chart and process-explorer-frontend packages to contain composeui
  • both packages are using material-icons instead of hosted stylesheets for deterministic builds, and better security
  • example-chart: dev server starts with "start" script
  • process-explorer-frontend: renamed files for inclusive language

@kruplm kruplm requested a review from a team February 22, 2023 10:53
lilla28
lilla28 previously approved these changes Feb 22, 2023
View reviewed changes
@kruplm kruplm force-pushed the naming-conventions branch from e55d59e to 41935e7 Compare February 22, 2023 11:45
@kruplm kruplm merged commit 08c19f8 into morganstanley:main Feb 22, 2023
@kruplm kruplm added this to the Compose as a web container milestone Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilla28 lilla28 lilla28 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Compose as a web container
Development

Successfully merging this pull request may close these issues.
2 participants
@kruplm @lilla28