Tests for composeui-node-launcher #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kruplm
commented
Feb 28, 2023
kruplm
commented
- For better testability the cli code has been refactored
- Rollup has been removed because it caused issues with the shebang
- Catching the exit code of the Shell
kruplm
force-pushed
the
node-launcher-tests
branch
2 times, most recently
from
41661b0 to
c1090fc
Compare
kruplm
force-pushed
the
node-launcher-tests
branch
from
c1090fc to
f34a472
Compare
kruplm
changed the title
kruplm
changed the title
BalassaMarton
suggested changes
Mar 2, 2023
BalassaMarton
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.