Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN download #180

Merged
merged 34 commits into from
Apr 11, 2023
Merged

CDN download #180

merged 34 commits into from
Apr 11, 2023

Conversation

kruplm
Copy link
Contributor

@kruplm kruplm commented Mar 21, 2023

Adding install script that downloads and decompresses the binary.

  • skipping the download if the COMPOSEUI_SKIP_DOWNLOAD environment variable is set to true
  • CDN URL can be provided via environment variable
  • Version is specified by the version number in the package.json or can be overridden by the COMPOSEUI_VERSION variable
  • The composeui-node-launcher launches the extracted binary unless an other path is specified by the COMPOSEUI_BINARY_FILE_PATH environment variable.
  • The user can specify the variables in an .npmrc file
  • README includes documentation and setup for development as well.
  • The downloading of the binaries is skipped on the CI since we should provide e2e tests/testing environment later.

psmulovics
psmulovics previously approved these changes Mar 21, 2023
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Merging #180 (a541c3c) into main (ffb7809) will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   74.07%   74.29%   +0.22%     
==========================================
  Files          95       94       -1     
  Lines        3495     3463      -32     
  Branches      135      131       -4     
==========================================
- Hits         2589     2573      -16     
+ Misses        906      890      -16     

see 2 files with indirect coverage changes

@kruplm kruplm changed the title CDN download [WIP] CDN download Mar 29, 2023
psmulovics
psmulovics previously approved these changes Mar 29, 2023
@kruplm kruplm marked this pull request as ready for review April 3, 2023 13:06
@kruplm kruplm requested a review from a team April 3, 2023 13:06
@kruplm kruplm merged commit 33f206e into morganstanley:main Apr 11, 2023
@kruplm kruplm added this to the Compose as a web container milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants