-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process Explorer -- Added Grpc Server #182
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #182 +/- ##
==========================================
- Coverage 76.21% 68.07% -8.14%
==========================================
Files 95 130 +35
Lines 3565 4530 +965
Branches 138 138
==========================================
+ Hits 2717 3084 +367
- Misses 847 1445 +598
Partials 1 1
|
kruplm
reviewed
Apr 20, 2023
lilla28
force-pushed
the
pe/grpc
branch
3 times, most recently
from
April 21, 2023 11:38
b12646d
to
acdb894
Compare
ZKRobi
requested changes
May 3, 2023
...anStanley.ComposeUI.ProcessExplorer/dotnet/src/ProcessExplorer.Core/ProcessInfoAggregator.cs
Outdated
Show resolved
Hide resolved
...anStanley.ComposeUI.ProcessExplorer/dotnet/src/ProcessExplorer.Core/ProcessInfoAggregator.cs
Outdated
Show resolved
Hide resolved
...anStanley.ComposeUI.ProcessExplorer/dotnet/src/ProcessExplorer.Core/ProcessInfoAggregator.cs
Outdated
Show resolved
Hide resolved
...anStanley.ComposeUI.ProcessExplorer/dotnet/src/ProcessExplorer.Core/ProcessInfoAggregator.cs
Outdated
Show resolved
Hide resolved
...anStanley.ComposeUI.ProcessExplorer/dotnet/src/ProcessExplorer.Core/ProcessInfoAggregator.cs
Outdated
Show resolved
Hide resolved
...anStanley.ComposeUI.ProcessExplorer/dotnet/src/ProcessExplorer.Core/ProcessInfoAggregator.cs
Outdated
Show resolved
Hide resolved
...seUI.ProcessExplorer/dotnet/src/ProcessExplorer.Abstractions/Processes/ProcessInfoMonitor.cs
Outdated
Show resolved
Hide resolved
...ComposeUI.ProcessExplorer/dotnet/src/ProcessExplorer.Core/Processes/WindowsProcessMonitor.cs
Outdated
Show resolved
Hide resolved
...ComposeUI.ProcessExplorer/dotnet/src/ProcessExplorer.Core/Processes/WindowsProcessMonitor.cs
Outdated
Show resolved
Hide resolved
...ComposeUI.ProcessExplorer/dotnet/src/ProcessExplorer.Core/Processes/WindowsProcessMonitor.cs
Outdated
Show resolved
Hide resolved
…GRpcProcessExplorer server, renamed variables, implemented IDisposable for IProcessInfoAggregator and IProcessMonitor instances
… change, null checks for server implementation, delegating launch/stop/restart request
…y's rules for Process Explorer
… initial, added IProcessManager, removed unnecessary files, changed ISubsystemLauncher and communicator API's
…itor, null checks, added IClientConnection for tracking the clients, added WindowsProcessMonitorTests, SubsystemControllerTests, SubsystemLauncherTests, fix of EndToEndTests, added sample programs for test cases, remove unnecessary methods, renamed variables, factory method
…ocessExplorer frontend
…moved the interfaces and entities under Abstraction package from LocalCollector. Fix EndToEndTests
ZKRobi
reviewed
May 15, 2023
...ns/MorganStanley.ComposeUI.ProcessExplorer/dotnet/src/LocalCollector/ProcessInfoCollector.cs
Outdated
Show resolved
Hide resolved
...ns/MorganStanley.ComposeUI.ProcessExplorer/dotnet/src/LocalCollector/ProcessInfoCollector.cs
Outdated
Show resolved
Hide resolved
...ns/MorganStanley.ComposeUI.ProcessExplorer/dotnet/src/LocalCollector/ProcessInfoCollector.cs
Outdated
Show resolved
Hide resolved
...seUI.ProcessExplorer/dotnet/src/ProcessExplorer.Abstractions/Processes/ProcessInfoMonitor.cs
Outdated
Show resolved
Hide resolved
…essInfoMonitor, added some IEnumerable extension methods, added comments
ZKRobi
reviewed
May 22, 2023
...ns/MorganStanley.ComposeUI.ProcessExplorer/dotnet/src/LocalCollector/ProcessInfoCollector.cs
Outdated
Show resolved
Hide resolved
ZKRobi
reviewed
May 22, 2023
...ns/MorganStanley.ComposeUI.ProcessExplorer/dotnet/src/LocalCollector/ProcessInfoCollector.cs
Outdated
Show resolved
Hide resolved
ZKRobi
previously approved these changes
May 22, 2023
ZKRobi
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are lot of changes -> lot of them are : moving components to other folder, adjust/changing namespaces (as I renamed the projects too).
Main changes:
Added EndToEndTests, some Unit tests.
Changes per commits:
Fix EndToEndTests