Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include version number in archive name #190

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

kruplm
Copy link
Contributor

@kruplm kruplm commented Apr 20, 2023

  • including missing v prefix from the CDN (install.js)
  • including version number in the name of the created archive (release.yml, install.js)

@kruplm kruplm marked this pull request as ready for review April 20, 2023 16:01
@kruplm kruplm requested a review from a team April 20, 2023 16:01
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #190 (763c763) into main (b19b1b2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #190   +/-   ##
=======================================
  Coverage   74.29%   74.29%           
=======================================
  Files          94       94           
  Lines        3463     3463           
  Branches      131      131           
=======================================
  Hits         2573     2573           
  Misses        890      890           

@kruplm kruplm merged commit b48c1bf into morganstanley:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants