Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix install #216

Merged
merged 5 commits into from
May 9, 2023
Merged

Fix install #216

merged 5 commits into from
May 9, 2023

Conversation

kruplm
Copy link
Contributor

@kruplm kruplm commented May 9, 2023

  • replacing unzipper with extract-zip
  • returning promise when download is ready
  • fixing zip extraction using extract-zip and returning a promise.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #216 (b05091a) into main (79aed1b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #216   +/-   ##
=======================================
  Coverage   76.21%   76.21%           
=======================================
  Files          95       95           
  Lines        3565     3565           
  Branches      138      138           
=======================================
  Hits         2717     2717           
  Misses        847      847           
  Partials        1        1

@kruplm kruplm marked this pull request as ready for review May 9, 2023 08:05
@kruplm kruplm requested a review from a team May 9, 2023 08:05
@kruplm kruplm merged commit b81b947 into morganstanley:main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilla28 lilla28 lilla28 approved these changes

@ztanczos ztanczos ztanczos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kruplm @ztanczos @lilla28