Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing typo: executeScrtiptFile -> executeScriptFile #219

Merged
merged 2 commits into from
May 10, 2023
Merged

Fixing typo: executeScrtiptFile -> executeScriptFile #219

merged 2 commits into from
May 10, 2023

Conversation

ztanczos
Copy link
Contributor

@ztanczos ztanczos commented May 10, 2023 •
edited
Loading

Fixing typo

@ztanczos ztanczos requested a review from a team May 10, 2023 07:23
kruplm
kruplm requested changes May 10, 2023
View reviewed changes
Copy link
Contributor

@kruplm kruplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the typo in the spec too. Thanks.

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #219 (2146928) into main (f43d460) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #219   +/-   ##
=======================================
  Coverage   76.21%   76.21%           
=======================================
  Files          95       95           
  Lines        3565     3565           
  Branches      138      138           
=======================================
  Hits         2717     2717           
  Misses        847      847           
  Partials        1        1
Impacted Files Coverage Δ
...mposeui-node-launcher/src/cli/executeScriptFile.ts 84.61% <ø> (ø)

@ztanczos ztanczos requested a review from kruplm May 10, 2023 08:12
kruplm
kruplm approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@kruplm kruplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ztanczos ztanczos merged commit c5b6bca into main May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruplm kruplm kruplm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ztanczos @kruplm