Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust namespaces, moving under prototypes folder, removed Tryouts #221

Merged
merged 1 commit into from
May 23, 2023

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented May 22, 2023

Adjust namespaces, moving under prototypes folder, removed Tryouts, edited lerna config, moved defaultApp under prototypes, unnecessary recreation of Module in ModulesPrototypes fix - state modification, after renaming the package fixing tests

@lilla28 lilla28 requested a review from a team May 22, 2023 16:36
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #221 (f827429) into main (469139e) will increase coverage by 0.44%.
The diff coverage is n/a.

❗ Current head f827429 differs from pull request most recent head acce541. Consider uploading reports for the commit acce541 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   68.48%   68.92%   +0.44%     
==========================================
  Files         129      129              
  Lines        4499     4499              
  Branches      138      138              
==========================================
+ Hits         3081     3101      +20     
+ Misses       1417     1397      -20     
  Partials        1        1              
Impacted Files Coverage Δ
...bstractions/Entities/Connections/ConnectionInfo.cs 100.00% <ø> (ø)
...ions/Entities/Connections/ConnectionMonitorInfo.cs 0.00% <ø> (ø)
...Entities/Connections/ConnectionStatusExtensions.cs 0.00% <ø> (ø)
...plorer.Abstractions/Entities/Modules/ModuleInfo.cs 16.66% <ø> (ø)
....Abstractions/Entities/ProcessInfoCollectorData.cs 94.73% <ø> (ø)
...actions/Entities/Registrations/RegistrationInfo.cs 100.00% <ø> (ø)
...plorer.Abstractions/Entities/RuntimeInformation.cs 0.00% <ø> (ø)
...Explorer.Abstractions/Extensions/EnumExtensions.cs 0.00% <ø> (ø)
...actions/Logging/SourceGeneratedLoggerExtensions.cs 21.05% <ø> (ø)
...y.ComposeUI.ProcessExplorer.Abstractions/Module.cs 0.00% <ø> (ø)
... and 25 more

... and 1 file with indirect coverage changes

@lilla28 lilla28 force-pushed the pe/ns branch 3 times, most recently from 46a9be3 to dc6042f Compare May 23, 2023 07:39
Copy link
Contributor

@kruplm kruplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

package.json Outdated Show resolved Hide resolved
kruplm
kruplm previously approved these changes May 23, 2023
…dited lerna config, moved defaultApp under prototypes, unnecessary recreation of Module in ModulesPrototypes fix - state modification
@lilla28 lilla28 merged commit 636d264 into morganstanley:main May 23, 2023
@lilla28 lilla28 deleted the pe/ns branch May 23, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants